Merge pull request #466 from claudep/issue464

Fixes #464 - Do not include 'upload_attachment' in widget settings if deactivated

django_summernote/test_django_summernote.py

@@ -270,6 +270,8 @@ def test_attachment_require_authentication(self):
 
     @patch('django_summernote.views.logger')
     def test_attachment_disable_attachment(self, mock_logging):
+        from django_summernote.widgets import SummernoteWidget
+
         url = reverse('django_summernote-upload_attachment')
         self.summernote_config['disable_attachment'] = True
 
@@ -279,6 +281,8 @@ def test_attachment_disable_attachment(self, mock_logging):
             self.assertDictEqual(response.json(), {"status": "false", "message": "Attachment module is disabled"})
             self.assertTrue(mock_logging.error.called)
 
+        self.assertNotIn('upload_attachment', SummernoteWidget().summernote_settings()['url'])
+
         self.summernote_config['disable_attachment'] = False
 
     @patch('django_summernote.views.logger')

django_summernote/widgets.py

@@ -25,9 +25,10 @@ def summernote_settings(self):
             'lang': lang,
             'url': {
                 'language': static('summernote/lang/summernote-' + lang + '.min.js'),
-                'upload_attachment': reverse('django_summernote-upload_attachment'),
             },
         })
+        if not get_config().get('disable_attachment', False):
+            summernote_settings['url']['upload_attachment'] = reverse('django_summernote-upload_attachment')
         return summernote_settings
 
     def value_from_datadict(self, data, files, name):