-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get a release in shape #16
Conversation
Tests pass with GHC-7.0.4 up to GHC-8.4.1.
I have built & tested this against lts-11 (ghc 8.2) and nightly-2018-03-14 (ghc 8.4). It builds and the tests pass on both. |
I pulled back a commit to make the Semigroup instance unconditional because I got a funky build error with GHC-7.0. Let me fix that first. |
Thanks a lot for the work @sjakobi! After some discussion I think an unconditional instance with an
So we don't introduce the dependency overhead on recent GHCs. Ping me when you want to discuss or if you want me to upload the release. |
03ff5b0 works for GHC-7.0.4 upwards.
@jaspervdj: Is there a reason for the constraint or is that simply a preference? |
mostly preference; if you can prove that it can be relaxed downwards, feel free to relax. |
This way it still works with LTS-2 :) |
Thanks again for all the work @sjakobi and @DanBurton! I have merged this to my fork and uploaded a release. This PR should be closed. I will open a new PR to get the changes in my fork back upstream. |
Thanks for stepping up, @jaspervdj! |
@lpsmith: I have asked @jaspervdj to make a release as there has been so little indication that you would do it reasonably soon.
I hope that you can understand this as there are so many people waiting! :)