Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with v9 multiple "events". #35

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Work with v9 multiple "events". #35

merged 3 commits into from
Nov 24, 2023

Conversation

igloo32
Copy link
Contributor

@igloo32 igloo32 commented Nov 23, 2023

No description provided.

@igloo32
Copy link
Contributor Author

igloo32 commented Nov 23, 2023

Updated to work with v9 multiple "events". Added option to Combine same rates in a day. Added option to highlight cheapest future rate. Added multiplier for display in pence/pounds

Copy link

@WhyAydan WhyAydan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me other than the commented line

Copy link

@WhyAydan WhyAydan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on the wrong side

octopus-energy-rates-card.js Outdated Show resolved Hide resolved
removed incorrect reference
Update octopus-energy-rates-card.js
@lozzd lozzd merged commit 7bb7699 into lozzd:main Nov 24, 2023
1 check passed
@bwduncan
Copy link

Hooray! Thank you so much 😁

It looks like the pastEntity and futureEntity attributes are not optional. The card doesn't load without them. I'm not really interested in yesterday's rates, but this should at least be reflected in the documentation. I'm happy to make a PR to do that, but I'm leaving this comment first in case I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants