Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for sctp load-balancer end-point health-check #84

Closed
PacketCrunch opened this issue Sep 5, 2022 · 5 comments
Closed

Support for sctp load-balancer end-point health-check #84

PacketCrunch opened this issue Sep 5, 2022 · 5 comments
Assignees
@TrekkieCoder
Labels
enhancement New feature or request goLang good first issue Good for newcomers
Milestone
Third beta releas...

Comments

@PacketCrunch
Copy link
Collaborator

We had gh-24 for load-balancer end-point health checks but sctp sessions require special handling as goLang's net package does not seem to support sctp yet.
@PacketCrunch PacketCrunch added enhancement New feature or request good first issue Good for newcomers labels Sep 5, 2022
@PacketCrunch PacketCrunch added this to the Second Beta Release 0.8.0 milestone Sep 5, 2022
@TrekkieCoder
Copy link
Collaborator

For tcp/udp, we do some trivial things here but need to cover this case.

@ragoragino
Copy link

ragoragino commented Sep 14, 2022 •
edited
Loading

@TrekkieCoder @dj-nlx Happy to take this one. I have taken a look at whether we could use something along the lines of native (for UNIX) SCTP support here. Let me know if it would make sense to open a PR with these changes (after some cleaning and also adding some tests), or whether other approaches would be preferred.

@PacketCrunch
Copy link
Collaborator Author

PacketCrunch commented Sep 15, 2022 •
edited
Loading

@ragoragino I think this approach is fine. Please go ahead !!

@UltraInstinct14
Copy link
Contributor

With upcoming release, we will monitor sctp end-point with ping. Although will wait for @ragoragino 's final patch.

@TrekkieCoder
Copy link
Collaborator

TrekkieCoder commented May 11, 2023 •
edited by UltraInstinct14
Loading

sctp-connect probe method is now supported. Refer to the commits 1, 2. Non-blocking mode and scale needs to be further tested.

UltraInstinct14 added a commit that referenced this issue May 12, 2023
@UltraInstinct14
Merge pull request #271 from TrekkieCoder/main
fb49b9b 
PR: gh-84 sctp-connect probing method is integrated
TrekkieCoder added a commit that referenced this issue May 14, 2023
@TrekkieCoder
gh-84 sctp-connect probing method is integrated
ae38a06 
(cherry picked from commit 903be3d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TrekkieCoder TrekkieCoder

Labels
enhancement New feature or request goLang good first issue Good for newcomers
Projects
None yet
Milestone
Third beta release 0.9.0
Development

No branches or pull requests
4 participants
@ragoragino @UltraInstinct14 @PacketCrunch @TrekkieCoder