Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds features from #152 that I am adding here to make the PRs more modular
Mostly this is some house keeping in the lighting, that makes it easier for other modules to use the light code
light.inc.wgsl
calculate_nth_light_ray
pbr.inc.wgsl
where what used to be four for loops one for each type oflight is now reduced to a single loop
light.inc.wgsl
andpbr.inc.wgsl
light.inc.wgsl
I would also like to discuss moving Lights (and their
light.inc.wgsl
) into core and leaving onlypbr.inc.wgsl
indotrix_pbr
but feel that should be another PR