Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Update to version 7.4.1 #25739

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

pamaury
Copy link
Contributor

@pamaury pamaury commented Dec 23, 2024

Bazel 7.4 has the new string_keyed_label_dict attribute which could be useful for #25580. It can be replaced by label_keyed_string_dict as a work around but it's really the wrong data structure and I would prefer to avoid that we keep using the wrong one for the job.

There is also bazelbuild/bazel#23585 could be very useful when we start adding bazel extensions.

Update the lock file at the same time.

Signed-off-by: Amaury Pouly <[email protected]>
Copy link
Contributor

@jwnrt jwnrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I’m surprised that the lockfile changed so much. Any ideas what caused that?

@pamaury
Copy link
Contributor Author

pamaury commented Dec 23, 2024

LGTM but I’m surprised that the lockfile changed so much. Any ideas what caused that?

No idea, that's quite weird. The only thing that comes to mind is that they either updated the format or they changed something in the resolution algorithm? It's also not clear to me that key order is stable.

@pamaury pamaury merged commit 0fc0d27 into lowRISC:master Jan 3, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants