Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clkmgr] Deglitch shadow storage error for MAIN clock domain #24622

Conversation

andreaskurth
Copy link
Contributor

@andreaskurth andreaskurth commented Sep 23, 2024

This is an ECO on the earlgrey_1.0.0 branch that adds a deglitcher on the err_storage output signal for the shadowed measurement control registers related only to the MAIN clock domain. For the IO_DIV4 clock domain, this deglitcher is not required (because the register and the alert sender are clocked with the IO_DIV4 clock), and the other clock domains (IO, IO_DIV2, and USB) are less critical and out of scope of this ECO.

On the master branch, a separate PR will add a deglitcher on the registers for all clock domains (even IO_DIV4, for simplicity).

@andreaskurth andreaskurth added IP:clkmgr ECO Accepted as an ECO labels Sep 23, 2024
@andreaskurth andreaskurth self-assigned this Sep 23, 2024
@andreaskurth andreaskurth changed the title [clkmgr] Deglitch shadow storage error for main clock domain [clkmgr] Deglitch shadow storage error for MAIN clock domain Sep 23, 2024
@andreaskurth
Copy link
Contributor Author

util/dvsim/dvsim.py hw/top_earlgrey/dv/top_earlgrey_sim_cfgs.hjson --select-cfgs clkmgr -i clkmgr_{smoke,frequency{,_timeout}} passes 100%.

@andreaskurth
Copy link
Contributor Author

CHANGE AUTHORIZED: hw/top_earlgrey/ip_autogen/clkmgr/rtl/clkmgr_reg_top.sv

ECO in progress; will be reverted if not successful.

Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @andreaskurth !
Thanks for the clear description, the plan sounds very reasonable to me.

@vogelpi
Copy link
Contributor

vogelpi commented Sep 23, 2024

CHANGE AUTHORIZED: hw/top_earlgrey/ip_autogen/clkmgr/rtl/clkmgr_reg_top.sv

@andreaskurth
Copy link
Contributor Author

Waiting for #24624 to land first, so that a tag can be created before this PR is merged

@andreaskurth andreaskurth merged commit a753275 into lowRISC:earlgrey_1.0.0 Sep 23, 2024
30 checks passed
@andreaskurth andreaskurth deleted the clkmgr-main_meas_ctrl_shadowed-err_storage-deglitch branch September 23, 2024 14:32
@vogelpi
Copy link
Contributor

vogelpi commented Sep 24, 2024

This is related to #24592 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ECO Accepted as an ECO IP:clkmgr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants