[rom] Make the banner message non-blocking #23820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cfrantz
commented
Jun 26, 2024
cfrantz
commented
- The ROM banner takes about 2 ms to be sent from the UART at 115200 bps. Rather than wait for it to complete transmission, emit the characters into the UART FIFO and proceed with boot. Hashing the FLASH contents and performing signature verification typically will take an additional 2.4 + 4.2 ms. There is no need to delay boot waiting for the UART.
- Fix the ROM's terminal states to wait for UART output to complete.
|
As discussed offline: an boot-speed optimization for UART output. |
timothytrippel
approved these changes
Jun 27, 2024
1. The ROM banner takes about 2 ms to be sent from the UART at 115200 bps. Rather than wait for it to complete transmission, emit the characters into the UART FIFO and proceed with boot. Hashing the FLASH contents and performing signature verification typically will take an additional 2.4 + 4.2 ms. There is no need to delay boot waiting for the UART. 2. Fix the ROM's terminal states to wait for UART output to complete. Signed-off-by: Chris Frantz <[email protected]>
moidx
approved these changes
Jun 27, 2024
|
The CI test failure is unrelated to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.