[hmac,rtl] FIFO Empty intr after FIFO seen full

[martin-velay]

• fix RTL issue [hmac,rtl] FIFO Empty interrupt raised after FIFO seen full #23738
• prevent to raise a FIFO empty interrupt when not required in case the FIFO is seen full while a stop is triggered.

[martin-velay]

FYI: in case somebody want to see the issue, you can get this commit 3551b1c and run the following command:
util/dvsim/dvsim.py hw/ip/hmac/dv/hmac_sim_cfg.hjson -i hmac_burst_wr -t xcelium --fixed-seed 54280119642660756066577499865407739571210164218606631048403677680909362592195 --gui

[vogelpi]

Thanks @martin-velay , the fix looks good to me but I suggest NOT to merge this right now to NOT cause any schedule impact for the TO (for details see my reasoning in the linked issue #23739 ).

I am not against fixing this bug but I think the bug is not critical enough to risk any delays. If others feel completely differently, I don't want block this though.

[martin-velay]

I have converted this PR into "draft" to avoid to get it merged by mistake. I'll change the status back into "ready for review" once the TO branch will have been created.

[vogelpi]

As documented here, it has been decided in the triage meeting 2024-06-21 to not do an ECO for this but to merge it post M5.

[vogelpi]

LGTM!

[vogelpi]

CHANGE AUTHORIZED: hw/ip/hmac/rtl/hmac.sv

[vogelpi]

I've marked the PR as ready and approved the changes. I don't suggest to merge this / ECO this but I would like this to be ready just in case another window for merging the change opens up again.

[andreaskurth]

CHANGE AUTHORIZED: hw/ip/hmac/rtl/hmac.sv

In case there's another synthesis opportunity; otherwise we'll have to revert this.

[martin-velay]

CHANGE AUTHORIZED: hw/ip/hmac/rtl/hmac.sv

In case there's another synthesis opportunity; otherwise we'll have to revert this.

@andreaskurth, if there is no other opportunity to integrate this fix in this TO, we can still merge this fix into the master afterward. No?

[vogelpi]

I am merging this now to create the next RC. We might need to revert this if we decide not to re-start synthesis. In this case, we would merge the change later to have it in potential follow-up spins / a future TO.

[martin-velay]

@vogelpi: as this RTL fix has been merged, should I keep this temporary workaround commit 55e2027?

[vogelpi]

@vogelpi: as this RTL fix has been merged, should I keep this temporary workaround commit 55e2027?

Please keep it in a local branch of yours in case we need to revert the RTL fix, thanks.

[martin-velay]

@vogelpi: as this RTL fix has been merged, should I keep this temporary workaround commit 55e2027?

Please keep it in a local branch of yours in case we need to revert the RTL fix, thanks.

Done! #23749 (comment)