[rom] Implement and test MGF1 and SHA2-based thash. #23710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadephilipoom
force-pushed
the
spx-sha2-prelim
branch
from
4966e6a
to
5097b63
Compare
Since these tests might be useful for debugging boot issues, it's helpful to be able to use the test ROM for them. Signed-off-by: Jade Philipoom <[email protected]>
jadephilipoom
force-pushed
the
spx-sha2-prelim
branch
from
5097b63
to
cd65037
Compare
The implementation is not yet used anywhere, but will be needed for SHA2-based SPHINCS+. Signed-off-by: Jade Philipoom <[email protected]>
The new thash implementation is not yet used, but will be needed for SHA2-based SPHINCS+. Signed-off-by: Jade Philipoom <[email protected]>
jadephilipoom
force-pushed
the
spx-sha2-prelim
branch
from
cd65037
to
c297122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #23144
These are preliminary steps for SHA2-based SPHINCS+; essentially the changes I can make without actually flipping the switch on the whole implementation. I've added an MGF1 implementation and a SHA2 version of the SPHINCS+
thashoperation, and tests for both that I created using a known-good third-party implementation.As a side change, I also added
test_romtargets for all SPHINCS+ subcomponent tests. I found this useful for debugging, especially since it might be helpful to test SPHINCS+ subcomponents on commits/targets where there are issues with the ROM boot flow.