[flash_ctrl/rtl] Enable SecFifoPtr for TL-UL FIFOs #23515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables the .Secure() option of the prim_fifo_sync FIFOs inside the tlul_adapter_sram used by the flash_ctrl module. On an error, the intg_error_o signal will be flagged. Signed-off-by: Pascal Nasahl <[email protected]>
johannheyszl
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Thanks @nasahlpa !
This enables an additional security feature we already had for the blocks we can use it.
Area impact should be super low because it concerns the very small fifo ctrs only.
Code change is small: parameter change to switch on transparent hardening; additional error signals; additional assertions
nasahlpa
added a commit
to nasahlpa/opentitan
that referenced
this pull request
Jun 12, 2024
With lowRISC#23515, the .Secure(1'b1) parameter was also enabled for the u_tlul_adapter_sram_imem.u_reqfifo and u_tlul_adapter_sram_imem.u_sramreqfifo. Hence, for the same reason as explained in lowRISC#23627 we should also exclude FI on these FIFOs. In addition, lowRISC#23627 only excluded the FI tests for the u_rptr. However, the same issue ('X all over the place) could also happen when faulting the u_wptr of the according FIFO. Hence, this commit also excludes FI for the u_wptr. Signed-off-by: Pascal Nasahl <[email protected]>
nasahlpa
added a commit
to nasahlpa/opentitan
that referenced
this pull request
Jun 12, 2024
With lowRISC#23515, the .Secure(1'b1) parameter was also enabled for the u_tlul_adapter_sram_imem.u_reqfifo and u_tlul_adapter_sram_imem.u_sramreqfifo. Hence, for the same reason as explained in lowRISC#23627 we should also exclude FI on these FIFOs. In addition, lowRISC#23627 only excluded the FI tests for the u_rptr. However, the same issue ('X all over the place) could also happen when faulting the u_wptr of the according FIFO. Hence, this commit also excludes FI for the u_wptr. Signed-off-by: Pascal Nasahl <[email protected]>
rswarbrick
pushed a commit
that referenced
this pull request
Jun 12, 2024
With #23515, the .Secure(1'b1) parameter was also enabled for the u_tlul_adapter_sram_imem.u_reqfifo and u_tlul_adapter_sram_imem.u_sramreqfifo. Hence, for the same reason as explained in #23627 we should also exclude FI on these FIFOs. In addition, #23627 only excluded the FI tests for the u_rptr. However, the same issue ('X all over the place) could also happen when faulting the u_wptr of the according FIFO. Hence, this commit also excludes FI for the u_wptr. Signed-off-by: Pascal Nasahl <[email protected]>
cfrantz
pushed a commit
to cfrantz/opentitan
that referenced
this pull request
Jun 14, 2024
With lowRISC#23515, the .Secure(1'b1) parameter was also enabled for the u_tlul_adapter_sram_imem.u_reqfifo and u_tlul_adapter_sram_imem.u_sramreqfifo. Hence, for the same reason as explained in lowRISC#23627 we should also exclude FI on these FIFOs. In addition, lowRISC#23627 only excluded the FI tests for the u_rptr. However, the same issue ('X all over the place) could also happen when faulting the u_wptr of the according FIFO. Hence, this commit also excludes FI for the u_wptr. Signed-off-by: Pascal Nasahl <[email protected]>
AlexJones0
pushed a commit
to AlexJones0/opentitan
that referenced
this pull request
Jul 8, 2024
With lowRISC#23515, the .Secure(1'b1) parameter was also enabled for the u_tlul_adapter_sram_imem.u_reqfifo and u_tlul_adapter_sram_imem.u_sramreqfifo. Hence, for the same reason as explained in lowRISC#23627 we should also exclude FI on these FIFOs. In addition, lowRISC#23627 only excluded the FI tests for the u_rptr. However, the same issue ('X all over the place) could also happen when faulting the u_wptr of the according FIFO. Hence, this commit also excludes FI for the u_wptr. Signed-off-by: Pascal Nasahl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables the .Secure() option of the prim_fifo_sync FIFOs inside the tlul_adapter_sram used by the flash_ctrl module.
On an error, the intg_error_o signal will be flagged.