[flash_ctrl/rtl] Enhance data intg in flash_phy_rd #23514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannheyszl
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
I have reviewed the source code in detail and I think this is a good modification.
As per discussion w/ @vogelpi , the area impact should be very low.
moidx
approved these changes
Jun 5, 2024
This commit enhances the data integrity protection inside the flash_phy_rd module by generating and appending the integrity tag before muxing the corresponding word using word_sel. Signed-off-by: Pascal Nasahl <[email protected]>
nasahlpa
force-pushed
the
flash_phy_rd_integrity
branch
from
868206c
to
75d6b4f
Compare
vogelpi
approved these changes
Jun 6, 2024
Comment on lines
+704
to
707
| tlul_data_integ_enc u_bus_inv_data_intg ( | ||
| .data_i({BusWidth{1'b1}}), | ||
| .data_intg_o(inv_data_integ) | ||
| ); |
There was a problem hiding this comment.
This integrity generator module has a constant input and thus synthesis will be able to optimize this which is great. This means the change really only adds one tlul_data_integ_enc instances even though the loop above instantiates two. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the data integrity protection inside the flash_phy_rd module by generating and appending the integrity tag before muxing the corresponding word using word_sel.