[ast] adding spi or iob mux #23356
Merged
[ast] adding spi or iob mux #23356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisnere
requested review from
andreaskurth and
vogelpi
and removed request for
msfschaffner
andreaskurth
requested changes
May 29, 2024
|
The linter run by kokoro currently fails because the port added to ast is not listed in the instance inside |
Signed-off-by: Eran Meisner <[email protected]>
| @@ -18,7 +18,7 @@ module ast #( | |||
| parameter int unsigned EntropyStreams = 4, | |||
| parameter int unsigned UsbCalibWidth = 20, | |||
| parameter int unsigned Ast2PadOutWidth = 9, | |||
| parameter int unsigned Pad2AstInWidth = 9 | |||
| parameter int unsigned Pad2AstInWidth = 8 | |||
There was a problem hiding this comment.
This change LGTM because PAD2AST_WIRES, which is used in the assignment to the padmux2ast_i port of ast, contains 8 signals.
Together with the previous commit, this resolves lowRISC#23280. Signed-off-by: Andreas Kurth <[email protected]>
andreaskurth
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ast] adding spi or iob mux as part of #23201
Adding #23125 changes as it wasn't approved the first time for some reason.