[top_earlgrey,pinmux] Add input disable pad attribute #23042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaskurth
changed the title
a-will
reviewed
May 9, 2024
a-will
reviewed
May 9, 2024
It seems that those files were outdated. Signed-off-by: Andreas Kurth <[email protected]>
a-will
reviewed
May 10, 2024
andreaskurth
force-pushed
the
pinmux-add-input-enable
branch
from
b858a61
to
b775813
Compare
andreaskurth
commented
May 13, 2024
andreaskurth
commented
May 13, 2024
hw/ip/prim_xilinx_ultrascale/rtl/prim_xilinx_ultrascale_pad_wrapper.sv
Outdated
Show resolved
Hide resolved
andreaskurth
changed the title
andreaskurth
requested review from
eshapira and
pamaury
and removed request for
a team
andreaskurth
changed the title
andreaskurth
force-pushed
the
pinmux-add-input-enable
branch
3 times, most recently
from
48d21dd
to
e638314
Compare
a-will
approved these changes
May 13, 2024
There was a problem hiding this comment.
IBUF_IBUFDISABLE turns out to only be particularly useful for HSTL, SSTL, and other V_REF-using IOSTANDARDs, so we can just drop the primitive, I think. If CI passes, though, leaving it in also seems fine.
It was my mistake to encourage actually supporting turning off buffers on the FPGA.
Signed-off-by: Andreas Kurth <[email protected]>
andreaskurth
force-pushed
the
pinmux-add-input-enable
branch
from
e638314
to
808336a
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an input disable attribute for pads that are controlled through pinmux. A later PR will add the attribute to manually instantiated pads (probably through sensor_ctrl).
This contributes to resolving #22990.