Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dv,cov] Improve config for toggle coverage exclusions #22891

Merged
merged 4 commits into from
Apr 30, 2024
Merged

[dv,cov] Improve config for toggle coverage exclusions #22891

merged 4 commits into from
Apr 30, 2024

Conversation

matutem
Copy link
Contributor

@matutem matutem commented Apr 30, 2024

  • Generate the exclusions for clkmgr and rstmgr from templates. This is easier to maintain since the information comes from the hjson files.
  • Create exclusion for pwrmgr with a single item.
  • Use module_name directive for exclusion since it makes it possible to use the same config at block and full chip level.
  • Add these exclusions to each block environment as well.
  • Add these exclusions to full chip.

Fixes #16640

@matutem
[dv,clkmgr] Generate node toggle exclusions from hjson
6e50fb9 
This creates a template file to exclude some nodes related to clock
gating tied to constants.
Use `module_node` for the block level toggle exclusion configs to
enable using the same config at the top level.

Fixes lowRISC#16640

Signed-off-by: Guillermo Maturana <[email protected]>
@matutem
[dv,pwrmgr] Create pwrmgr toggle coverage exclusion config
a33e733 
Use `module_node` for the block level toggle exclusion configs to
enable using the same config at the top level.

Signed-off-by: Guillermo Maturana <[email protected]>
@matutem
[dv,rstmgr] Generate node toggle exclusions from hjson
53023d2 
This creates a template file to exclude some output resets and reset enables
tied to constants.
Use `module_node` for the block level toggle exclusion configs to
enable using the same config at the top level.

Fixes lowRISC#16640

Signed-off-by: Guillermo Maturana <[email protected]>
@matutem matutem requested a review from a team as a code owner April 30, 2024 05:54
@matutem matutem requested review from rswarbrick and removed request for a team April 30, 2024 05:55
@matutem
[dv,top_level] Fix coverage toggle exclusion configs
57ab246 
Use `module_node` for the block level toggle exclusion configs.
This enables using the same config at the top level.

Fixes lowRISC#16640

Signed-off-by: Guillermo Maturana <[email protected]>
@matutem matutem merged commit e9925bd into lowRISC:master Apr 30, 2024
31 of 32 checks passed
@matutem matutem deleted the cov_excl branch April 30, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rswarbrick rswarbrick rswarbrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[clkmgr] Template exclusions
2 participants
@matutem @rswarbrick