-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i2c] Reduce counter sizes to save area #22577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these optimizations, @a-will. Area matters these days :-)
LGTM; I just have suggestions about capturing this in the documentation. (And obviously please only rebase & merge this after the PR that this depends on got merged.)
Ah, kokoro provided results. I'll fix the lint errors. |
Reduce counter sizes to only the widths needed to support Standard mode at a 1 GHz core clock. Signed-off-by: Alexander Williams <[email protected]>
FYI, the We're not really sure why the test fails yet, but OpenOCD can't connect through JTAG after the chip wakes up from deep sleep:
|
Given the content of this PR, it is very highly unlikely to be the cause, though. |
I think you're right. Maybe it's just due to the bitstreams available in the cache before and after this PR merged. Apologies for the noise. |
Reduce counter sizes to only the widths needed to support Standard mode at a 1 GHz core clock.
In the FPGA implementation, this saves 44 flops (~4%) and over 100 LUTs (~6.6%). The granularity of the FPGA area is large, so the size of the savings can be misleading, but compared to what we had prior to the FSM split, this brings us to +29 flops, -59 LUTs for the whole chain of commits.
This builds on #22551. Only the last commit is new.