Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keymgr] Use non-deterministic decoy values for KMAC and sideload ports #22535

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

vogelpi
Copy link
Contributor

@vogelpi vogelpi commented Apr 11, 2024

Previously, the two shares of the masked values forwarded to KMAC and the sideload ports would be equal when not used. This is non-ideal as the effective value observed on the sideload ports and by KMAC becomes then 0 which may potentially be exploited.

This resolves #8120.

Previously, the two shares of the masked values forwarded to KMAC and
the sideload ports would be equal when not used. This is non-ideal as
the effective value observed on the sideload ports and by KMAC becomes
then 0 which may potentially be exploited.

This resolves lowRISC#8120.

Signed-off-by: Pirmin Vogel <[email protected]>
@andreaskurth andreaskurth added this to the Backlog milestone Apr 12, 2024
Copy link
Contributor

@andreaskurth andreaskurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @vogelpi

@vogelpi vogelpi merged commit 5d4515e into lowRISC:master Apr 12, 2024
31 checks passed
@vogelpi vogelpi deleted the keymgr-kmac-if-fix branch April 18, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[keymgr] Security enhancement
2 participants