[flash_ctrl] Revert back to using per-bank, dedicated scrambling modules #22191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An inspection of the DV issues arising from the change to share a single scrambling module between Flash banks revealed that there are indeed some corner cases that are not properly handled by the current design. Fixing those corner cases is tricky and may lead to further issues. For this reason, this commit reverts the following commits for the time being: - [doc,flash_ctrl] Fix inconsistency and typo in documentation 3a35e26 - [flash_ctrl] Use redundant arbiters in scrambling module a63c2d9 - [flash_ctrl] Share flash_scrambling module among banks c95dc32 This is related to lowRISC#22089. Signed-off-by: Pirmin Vogel <[email protected]>
This was referenced Mar 22, 2024
|
Closing as we managed to fix the corner cases (an actual RTL bug). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An inspection of the DV issues arising from the change to share a single scrambling module between Flash banks revealed that there are indeed some corner cases that are not properly handled by the current design. Fixing those corner cases is tricky and may lead to further issues.
For this reason, this commit reverts the following commits for the time being:
[doc,flash_ctrl] Fix inconsistency and typo in documentation 3a35e26
[flash_ctrl] Use redundant arbiters in scrambling module a63c2d9
[flash_ctrl] Share flash_scrambling module among banks c95dc32
This is related to #22089.