Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[entropy_src] Reduce depth of Observe FIFO #22087

Merged
merged 1 commit into from
Mar 19, 2024
Merged

[entropy_src] Reduce depth of Observe FIFO #22087

merged 1 commit into from
Mar 19, 2024

Conversation

vogelpi
Copy link
Contributor

@vogelpi vogelpi commented Mar 18, 2024

Halving the depth of the observe FIFO allows saving 1024 FFs. With a FIFO size of 1 kbit, it is still possible to buffer a full, contiguous 1024-sample window in single-channel mode. For the multi-channel mode, an experiment on the engineering sample showed that Ibex is fast enough in reading out the FIFO to avoid it overflowing during read out.

First block-level tests look good, I am running a full regression now. What also should be done:

  • Check the affected TLTs explicitly.
  • Check the documentation.

I'll continue this work later tonight.

@vogelpi vogelpi requested a review from a team as a code owner March 18, 2024 17:15
@vogelpi vogelpi requested review from HU90m, msfschaffner, h-filali and andreaskurth and removed request for a team and HU90m March 18, 2024 17:15
@msfschaffner msfschaffner mentioned this pull request Mar 18, 2024
Merged
@msfschaffner
Copy link
Contributor

The Veriblelint issue is unrelated and can be ignored.
The kokoro issue is a license warning and can be ignored as well.

@vogelpi
Copy link
Contributor Author

vogelpi commented Mar 18, 2024

Update: also the documentation is aligned now and the following TLTs have been successfully tested:

  • chip_sw_entropy_src_ast_rng_req

These tests failed, but they've also been failing on master for some time now:

  • chip_sw_csrng_lc_hw_debug_en_test
  • chip_sw_ast_clk_rst_inputs

Still running:

  • entropy_src_fw_ovr_test
  • entropy_src_fw_observe_many_contiguous
  • entropy_src_fw_override_test

@vogelpi
Copy link
Contributor Author

vogelpi commented Mar 18, 2024

On the block-level DV side, I got no new failures:

ENTROPY_SRC Simulation Results

Monday March 18 2024 17:10:52 UTC

GitHub Revision: 43924a4ea6

Branch: HEAD

Testplan

Simulator: XCELIUM

Test Results

Stage Name Tests Max Job Runtime Simulated Time Passing Total Pass Rate
V1 smoke entropy_src_smoke 7.000s 20.880us 50 50 100.00
V1 csr_hw_reset entropy_src_csr_hw_reset 5.000s 72.742us 5 5 100.00
V1 csr_rw entropy_src_csr_rw 5.000s 29.825us 20 20 100.00
V1 csr_bit_bash entropy_src_csr_bit_bash 24.000s 3.188ms 5 5 100.00
V1 csr_aliasing entropy_src_csr_aliasing 9.000s 166.612us 5 5 100.00
V1 csr_mem_rw_with_rand_reset entropy_src_csr_mem_rw_with_rand_reset 6.000s 88.285us 20 20 100.00
V1 regwen_csr_and_corresponding_lockable_csr entropy_src_csr_rw 5.000s 29.825us 20 20 100.00
    entropy_src_csr_aliasing 9.000s 166.612us 5 5 100.00
V1   TOTAL     105 105 100.00
V2 firmware entropy_src_smoke 7.000s 20.880us 50 50 100.00
    entropy_src_rng 5.167m 10.064ms 298 300 99.33
    entropy_src_fw_ov 2.667m 5.033ms 289 300 96.33
V2 firmware_mode entropy_src_fw_ov 2.667m 5.033ms 289 300 96.33
V2 rng_mode entropy_src_rng 5.167m 10.064ms 298 300 99.33
V2 rng_max_rate entropy_src_rng_max_rate 8.917m 10.037ms 385 400 96.25
V2 health_checks entropy_src_rng 5.167m 10.064ms 298 300 99.33
V2 conditioning entropy_src_rng 5.167m 10.064ms 298 300 99.33
V2 interrupts entropy_src_rng 5.167m 10.064ms 298 300 99.33
V2 alerts entropy_src_rng 5.167m 10.064ms 298 300 99.33
    entropy_src_functional_alerts 8.000s 269.179us 50 50 100.00
V2 stress_all entropy_src_stress_all 15.000s 1.594ms 50 50 100.00
V2 functional_errors entropy_src_functional_errors 9.750m 10.012ms 970 1000 97.00
V2 firmware_ov_read_contiguous_data entropy_src_fw_ov_contiguous 26.000s 1.350ms 50 50 100.00
V2 intr_test entropy_src_intr_test 7.000s 21.033us 50 50 100.00
V2 alert_test entropy_src_alert_test 7.000s 17.407us 50 50 100.00
V2 tl_d_oob_addr_access entropy_src_tl_errors 11.000s 396.433us 20 20 100.00
V2 tl_d_illegal_access entropy_src_tl_errors 11.000s 396.433us 20 20 100.00
V2 tl_d_outstanding_access entropy_src_csr_hw_reset 5.000s 72.742us 5 5 100.00
    entropy_src_csr_rw 5.000s 29.825us 20 20 100.00
    entropy_src_csr_aliasing 9.000s 166.612us 5 5 100.00
    entropy_src_same_csr_outstanding 7.000s 615.464us 20 20 100.00
V2 tl_d_partial_access entropy_src_csr_hw_reset 5.000s 72.742us 5 5 100.00
    entropy_src_csr_rw 5.000s 29.825us 20 20 100.00
    entropy_src_csr_aliasing 9.000s 166.612us 5 5 100.00
    entropy_src_same_csr_outstanding 7.000s 615.464us 20 20 100.00
V2   TOTAL     2232 2290 97.47
V2S tl_intg_err entropy_src_sec_cm 8.000s 54.680us 5 5 100.00
    entropy_src_tl_intg_err 9.000s 96.848us 20 20 100.00
V2S sec_cm_config_regwen entropy_src_rng 5.167m 10.064ms 298 300 99.33
    entropy_src_cfg_regwen 7.000s 15.777us 50 50 100.00
V2S sec_cm_config_mubi entropy_src_rng 5.167m 10.064ms 298 300 99.33
V2S sec_cm_config_redun entropy_src_rng 5.167m 10.064ms 298 300 99.33
V2S sec_cm_intersig_mubi entropy_src_rng 5.167m 10.064ms 298 300 99.33
    entropy_src_fw_ov 2.667m 5.033ms 289 300 96.33
V2S sec_cm_main_sm_fsm_sparse entropy_src_functional_errors 9.750m 10.012ms 970 1000 97.00
    entropy_src_sec_cm 8.000s 54.680us 5 5 100.00
V2S sec_cm_ack_sm_fsm_sparse entropy_src_functional_errors 9.750m 10.012ms 970 1000 97.00
    entropy_src_sec_cm 8.000s 54.680us 5 5 100.00
V2S sec_cm_rng_bkgn_chk entropy_src_rng 5.167m 10.064ms 298 300 99.33
V2S sec_cm_ctr_redun entropy_src_functional_errors 9.750m 10.012ms 970 1000 97.00
    entropy_src_sec_cm 8.000s 54.680us 5 5 100.00
V2S sec_cm_ctr_local_esc entropy_src_functional_errors 9.750m 10.012ms 970 1000 97.00
V2S sec_cm_esfinal_rdata_bus_consistency entropy_src_functional_alerts 8.000s 269.179us 50 50 100.00
V2S sec_cm_tile_link_bus_integrity entropy_src_tl_intg_err 9.000s 96.848us 20 20 100.00
V2S   TOTAL     75 75 100.00
V3 external_health_tests entropy_src_rng_with_xht_rsps 4.767m 10.021ms 50 50 100.00
V3   TOTAL     50 50 100.00
  Unmapped tests entropy_src_intr 23.000s 2.807ms 42 50 84.00
    TOTAL     2504 2570 97.43

Failure Buckets

  • UVM_FATAL (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.fifo_state_err (addr=*) == * has 12 failures:

    • Test entropy_src_functional_errors has 12 failures.

      • 30.entropy_src_functional_errors.57821236999170911389374836443771297753670180970977426531590681726898338930098
        Line 154, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/30.entropy_src_functional_errors/latest/run.log

          UVM_FATAL @ 10042737474 ps: (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.fifo_state_err (addr=0x5fe5f8d8) == 0x1
  UVM_INFO @ 10042737474 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

      • 122.entropy_src_functional_errors.12258207911194878802948396880155904358586418283041741885355043290703642052678
        Line 154, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/122.entropy_src_functional_errors/latest/run.log

          UVM_FATAL @ 10018442551 ps: (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.fifo_state_err (addr=0xce196fd8) == 0x1
  UVM_INFO @ 10018442551 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

      • ... and 10 more failures.

  • UVM_FATAL (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.fifo_read_err (addr=*) == * has 12 failures:

    • Test entropy_src_functional_errors has 12 failures.

      • 62.entropy_src_functional_errors.58317036967082666076014767104883736120297751959416435453267735789713622655692
        Line 154, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/62.entropy_src_functional_errors/latest/run.log

          UVM_FATAL @ 10073867007 ps: (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.fifo_read_err (addr=0xda6a49d8) == 0x1
  UVM_INFO @ 10073867007 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

      • 121.entropy_src_functional_errors.32939474552079611941796477566443671856539519068905258423396642879489528743220
        Line 154, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/121.entropy_src_functional_errors/latest/run.log

          UVM_FATAL @ 10023192763 ps: (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.fifo_read_err (addr=0xcd0be9d8) == 0x1
  UVM_INFO @ 10023192763 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

      • ... and 10 more failures.

  • UVM_ERROR (cip_base_scoreboard.sv:242) [scoreboard] Check failed expected_alert[alert_name].expected == * (* [*] vs * [*]) alert fatal_alert triggered unexpectedly has 10 failures:

    • Test entropy_src_fw_ov has 10 failures.

      • 10.entropy_src_fw_ov.53338546369351147830339278103602407665931745096215236339986154916652301624437
        Line 201, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/10.entropy_src_fw_ov/latest/run.log

          UVM_ERROR @ 2174578862 ps: (cip_base_scoreboard.sv:242) [uvm_test_top.env.scoreboard] Check failed expected_alert[alert_name].expected == 1 (0 [0x0] vs 1 [0x1]) alert fatal_alert triggered unexpectedly
  UVM_INFO @ 2174578862 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

      • 84.entropy_src_fw_ov.33398070227105552121013533372439818982363524859982799627376649773259324104411
        Line 201, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/84.entropy_src_fw_ov/latest/run.log

          UVM_ERROR @ 1874498399 ps: (cip_base_scoreboard.sv:242) [uvm_test_top.env.scoreboard] Check failed expected_alert[alert_name].expected == 1 (0 [0x0] vs 1 [0x1]) alert fatal_alert triggered unexpectedly
  UVM_INFO @ 1874498399 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

      • ... and 8 more failures.

  • UVM_FATAL (entropy_src_base_vseq.sv:448) [entropy_src_rng_vseq] Timeout encountered while reading TlSrcObserveFIFO has 10 failures:

    • Test entropy_src_rng_max_rate has 10 failures.

      • 50.entropy_src_rng_max_rate.13537851687682562004826217509152345127253678253750537256650118267539658573952
        Line 3602, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/50.entropy_src_rng_max_rate/latest/run.log

          UVM_FATAL @ 8023885429 ps: (entropy_src_base_vseq.sv:448) [uvm_test_top.env.virtual_sequencer.entropy_src_rng_vseq] Timeout encountered while reading TlSrcObserveFIFO
  UVM_INFO @ 8023885429 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

      • 79.entropy_src_rng_max_rate.5028339047366192533005395446779632652250658494442617748780476099867966463351
        Line 552, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/79.entropy_src_rng_max_rate/latest/run.log

          UVM_FATAL @ 1646322146 ps: (entropy_src_base_vseq.sv:448) [uvm_test_top.env.virtual_sequencer.entropy_src_rng_vseq] Timeout encountered while reading TlSrcObserveFIFO
  UVM_INFO @ 1646322146 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

      • ... and 8 more failures.

  • xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_entropy_src_*/rtl/entropy_src_core.sv,3387): Assertion Final_PreconFifoPushedPostStartup_A has failed has 8 failures:

    • Test entropy_src_intr has 8 failures.

      • 1.entropy_src_intr.76996431287204279455894590583311329705209531540673924611444955187481959631416
        Line 197, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/1.entropy_src_intr/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_entropy_src_0.1/rtl/entropy_src_core.sv,3387): (time 3288948348 PS) Assertion tb.dut.u_entropy_src_core.Final_PreconFifoPushedPostStartup_A has failed
  xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
  xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
  xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
  xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.

      • 5.entropy_src_intr.81399488564668519789761175947726660564880861318935623662116753382313024323753
        Line 197, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/5.entropy_src_intr/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_entropy_src_0.1/rtl/entropy_src_core.sv,3387): (time 519930836 PS) Assertion tb.dut.u_entropy_src_core.Final_PreconFifoPushedPostStartup_A has failed
  xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
  xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
  xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
  xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.

      • ... and 6 more failures.

  • UVM_FATAL (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.sfifo_observe_err (addr=*) == * has 6 failures:

    • Test entropy_src_functional_errors has 6 failures.

      • 157.entropy_src_functional_errors.76266914566011573609946664847937347413630891835481572094638268175040397167436
        Line 154, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/157.entropy_src_functional_errors/latest/run.log

          UVM_FATAL @ 10015606517 ps: (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.sfifo_observe_err (addr=0x7cbd1bd8) == 0x1
  UVM_INFO @ 10015606517 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

      • 200.entropy_src_functional_errors.107459823635817182597659047661069327453872246314043228732067453704369594874200
        Line 154, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/200.entropy_src_functional_errors/latest/run.log

          UVM_FATAL @ 10014776315 ps: (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.sfifo_observe_err (addr=0xc5b7d3d8) == 0x1
  UVM_INFO @ 10014776315 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

      • ... and 4 more failures.

  • xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_sha3_*/rtl/sha*.sv,505): Assertion KeccakIdleWhenNoRunHs_A has failed has 5 failures:

    • Test entropy_src_rng_max_rate has 3 failures.

      • 30.entropy_src_rng_max_rate.43669038798347356606364372477386891708842464154482743953462961253191007312812
        Line 5292, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/30.entropy_src_rng_max_rate/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_sha3_0.1/rtl/sha3.sv,505): (time 10081509392 PS) Assertion tb.dut.u_entropy_src_core.u_sha3.KeccakIdleWhenNoRunHs_A has failed
  UVM_ERROR @ 10081509392 ps: (sha3.sv:505) [ASSERT FAILED] KeccakIdleWhenNoRunHs_A
  UVM_INFO @ 10081509392 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

      • 35.entropy_src_rng_max_rate.38226058601310527602372740902750344178510062677579296096546915538882673727117
        Line 5044, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/35.entropy_src_rng_max_rate/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_sha3_0.1/rtl/sha3.sv,505): (time 10000255942 PS) Assertion tb.dut.u_entropy_src_core.u_sha3.KeccakIdleWhenNoRunHs_A has failed
  UVM_ERROR @ 10000255942 ps: (sha3.sv:505) [ASSERT FAILED] KeccakIdleWhenNoRunHs_A
  UVM_INFO @ 10000255942 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

      • ... and 1 more failures.

    • Test entropy_src_rng has 2 failures.

      • 206.entropy_src_rng.103095858364156404689733577356642794893420902795832583750447299445026962054591
        Line 2132, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/206.entropy_src_rng/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_sha3_0.1/rtl/sha3.sv,505): (time 10006457971 PS) Assertion tb.dut.u_entropy_src_core.u_sha3.KeccakIdleWhenNoRunHs_A has failed
  UVM_ERROR @ 10006457971 ps: (sha3.sv:505) [ASSERT FAILED] KeccakIdleWhenNoRunHs_A
  UVM_INFO @ 10006457971 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

      • 277.entropy_src_rng.10218765318577669684772589837900679687457166425146218520160727932628675371732
        Line 3376, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/277.entropy_src_rng/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_sha3_0.1/rtl/sha3.sv,505): (time 10073990988 PS) Assertion tb.dut.u_entropy_src_core.u_sha3.KeccakIdleWhenNoRunHs_A has failed
  UVM_ERROR @ 10073990988 ps: (sha3.sv:505) [ASSERT FAILED] KeccakIdleWhenNoRunHs_A
  UVM_INFO @ 10073990988 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

  • xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_entropy_src_*/rtl/entropy_src_core.sv,3375): Assertion Final_EsfinalFifoPushedPostStartup_A has failed has 1 failures:

    • Test entropy_src_rng_max_rate has 1 failures.

      • 29.entropy_src_rng_max_rate.103372143814982320608707777089551149521646032684346793570205595087258379627791
        Line 4341, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/29.entropy_src_rng_max_rate/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_entropy_src_0.1/rtl/entropy_src_core.sv,3375): (time 10059111208 PS) Assertion tb.dut.u_entropy_src_core.Final_EsfinalFifoPushedPostStartup_A has failed
  xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
  xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
  xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
  xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.

  • xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_entropy_src_*/rtl/entropy_src_core.sv,3163): Assertion AtReset_EsbitFifoPushedIntoPosthtFifo_A has failed has 1 failures:

    • Test entropy_src_fw_ov has 1 failures.

      • 170.entropy_src_fw_ov.52615235015724664584965654782282422443413719510715433637996484048496250602052
        Line 680, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/170.entropy_src_fw_ov/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_entropy_src_0.1/rtl/entropy_src_core.sv,3163): (time 4187403697 PS) Assertion tb.dut.u_entropy_src_core.AtReset_EsbitFifoPushedIntoPosthtFifo_A has failed
  UVM_ERROR @ 4187403697 ps: (entropy_src_core.sv:3163) [ASSERT FAILED] AtReset_EsbitFifoPushedIntoPosthtFifo_A
  UVM_INFO @ 4187403697 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

  • UVM_ERROR (cip_base_scoreboard.sv:302) scoreboard [scoreboard] alert recov_alert did not trigger max_delay:* has 1 failures:

    • Test entropy_src_rng_max_rate has 1 failures.

      • 296.entropy_src_rng_max_rate.18141511378691529040367643777542872286800865523148623787758567428344086013439
        Line 307, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/296.entropy_src_rng_max_rate/latest/run.log

          UVM_ERROR @ 547476028 ps: (cip_base_scoreboard.sv:302) uvm_test_top.env.scoreboard [uvm_test_top.env.scoreboard] alert recov_alert did not trigger max_delay:5
  UVM_INFO @ 547476028 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

ENTROPY_SRC Simulation Results
Monday March 18 2024 17:10:52 UTC
GitHub Revision: 43924a4ea6
Branch: HEAD
Testplan
Simulator: XCELIUM
Test Results
Stage Name Tests Max Job Runtime Simulated Time Passing Total Pass Rate
V1 smoke entropy_src_smoke 7.000s 20.880us 50 50 100.00
V1 csr_hw_reset entropy_src_csr_hw_reset 5.000s 72.742us 5 5 100.00
V1 csr_rw entropy_src_csr_rw 5.000s 29.825us 20 20 100.00
V1 csr_bit_bash entropy_src_csr_bit_bash 24.000s 3.188ms 5 5 100.00
V1 csr_aliasing entropy_src_csr_aliasing 9.000s 166.612us 5 5 100.00
V1 csr_mem_rw_with_rand_reset entropy_src_csr_mem_rw_with_rand_reset 6.000s 88.285us 20 20 100.00
V1 regwen_csr_and_corresponding_lockable_csr entropy_src_csr_rw 5.000s 29.825us 20 20 100.00
entropy_src_csr_aliasing 9.000s 166.612us 5 5 100.00
V1 TOTAL 105 105 100.00
V2 firmware entropy_src_smoke 7.000s 20.880us 50 50 100.00
entropy_src_rng 5.167m 10.064ms 298 300 99.33
entropy_src_fw_ov 2.667m 5.033ms 289 300 96.33
V2 firmware_mode entropy_src_fw_ov 2.667m 5.033ms 289 300 96.33
V2 rng_mode entropy_src_rng 5.167m 10.064ms 298 300 99.33
V2 rng_max_rate entropy_src_rng_max_rate 8.917m 10.037ms 385 400 96.25
V2 health_checks entropy_src_rng 5.167m 10.064ms 298 300 99.33
V2 conditioning entropy_src_rng 5.167m 10.064ms 298 300 99.33
V2 interrupts entropy_src_rng 5.167m 10.064ms 298 300 99.33
V2 alerts entropy_src_rng 5.167m 10.064ms 298 300 99.33
entropy_src_functional_alerts 8.000s 269.179us 50 50 100.00
V2 stress_all entropy_src_stress_all 15.000s 1.594ms 50 50 100.00
V2 functional_errors entropy_src_functional_errors 9.750m 10.012ms 970 1000 97.00
V2 firmware_ov_read_contiguous_data entropy_src_fw_ov_contiguous 26.000s 1.350ms 50 50 100.00
V2 intr_test entropy_src_intr_test 7.000s 21.033us 50 50 100.00
V2 alert_test entropy_src_alert_test 7.000s 17.407us 50 50 100.00
V2 tl_d_oob_addr_access entropy_src_tl_errors 11.000s 396.433us 20 20 100.00
V2 tl_d_illegal_access entropy_src_tl_errors 11.000s 396.433us 20 20 100.00
V2 tl_d_outstanding_access entropy_src_csr_hw_reset 5.000s 72.742us 5 5 100.00
entropy_src_csr_rw 5.000s 29.825us 20 20 100.00
entropy_src_csr_aliasing 9.000s 166.612us 5 5 100.00
entropy_src_same_csr_outstanding 7.000s 615.464us 20 20 100.00
V2 tl_d_partial_access entropy_src_csr_hw_reset 5.000s 72.742us 5 5 100.00
entropy_src_csr_rw 5.000s 29.825us 20 20 100.00
entropy_src_csr_aliasing 9.000s 166.612us 5 5 100.00
entropy_src_same_csr_outstanding 7.000s 615.464us 20 20 100.00
V2 TOTAL 2232 2290 97.47
V2S tl_intg_err entropy_src_sec_cm 8.000s 54.680us 5 5 100.00
entropy_src_tl_intg_err 9.000s 96.848us 20 20 100.00
V2S sec_cm_config_regwen entropy_src_rng 5.167m 10.064ms 298 300 99.33
entropy_src_cfg_regwen 7.000s 15.777us 50 50 100.00
V2S sec_cm_config_mubi entropy_src_rng 5.167m 10.064ms 298 300 99.33
V2S sec_cm_config_redun entropy_src_rng 5.167m 10.064ms 298 300 99.33
V2S sec_cm_intersig_mubi entropy_src_rng 5.167m 10.064ms 298 300 99.33
entropy_src_fw_ov 2.667m 5.033ms 289 300 96.33
V2S sec_cm_main_sm_fsm_sparse entropy_src_functional_errors 9.750m 10.012ms 970 1000 97.00
entropy_src_sec_cm 8.000s 54.680us 5 5 100.00
V2S sec_cm_ack_sm_fsm_sparse entropy_src_functional_errors 9.750m 10.012ms 970 1000 97.00
entropy_src_sec_cm 8.000s 54.680us 5 5 100.00
V2S sec_cm_rng_bkgn_chk entropy_src_rng 5.167m 10.064ms 298 300 99.33
V2S sec_cm_ctr_redun entropy_src_functional_errors 9.750m 10.012ms 970 1000 97.00
entropy_src_sec_cm 8.000s 54.680us 5 5 100.00
V2S sec_cm_ctr_local_esc entropy_src_functional_errors 9.750m 10.012ms 970 1000 97.00
V2S sec_cm_esfinal_rdata_bus_consistency entropy_src_functional_alerts 8.000s 269.179us 50 50 100.00
V2S sec_cm_tile_link_bus_integrity entropy_src_tl_intg_err 9.000s 96.848us 20 20 100.00
V2S TOTAL 75 75 100.00
V3 external_health_tests entropy_src_rng_with_xht_rsps 4.767m 10.021ms 50 50 100.00
V3 TOTAL 50 50 100.00
Unmapped tests entropy_src_intr 23.000s 2.807ms 42 50 84.00
TOTAL 2504 2570 97.43
Failure Buckets

UVM_FATAL (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.fifo_state_err (addr=*) == * has 12 failures:
    Test entropy_src_functional_errors has 12 failures.

        30.entropy_src_functional_errors.57821236999170911389374836443771297753670180970977426531590681726898338930098
        Line 154, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/30.entropy_src_functional_errors/latest/run.log

          UVM_FATAL @ 10042737474 ps: (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.fifo_state_err (addr=0x5fe5f8d8) == 0x1
          UVM_INFO @ 10042737474 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---
          
          

        122.entropy_src_functional_errors.12258207911194878802948396880155904358586418283041741885355043290703642052678
        Line 154, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/122.entropy_src_functional_errors/latest/run.log

          UVM_FATAL @ 10018442551 ps: (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.fifo_state_err (addr=0xce196fd8) == 0x1
          UVM_INFO @ 10018442551 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---
          
          

        ... and 10 more failures.

UVM_FATAL (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.fifo_read_err (addr=*) == * has 12 failures:
    Test entropy_src_functional_errors has 12 failures.

        62.entropy_src_functional_errors.58317036967082666076014767104883736120297751959416435453267735789713622655692
        Line 154, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/62.entropy_src_functional_errors/latest/run.log

          UVM_FATAL @ 10073867007 ps: (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.fifo_read_err (addr=0xda6a49d8) == 0x1
          UVM_INFO @ 10073867007 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---
          
          

        121.entropy_src_functional_errors.32939474552079611941796477566443671856539519068905258423396642879489528743220
        Line 154, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/121.entropy_src_functional_errors/latest/run.log

          UVM_FATAL @ 10023192763 ps: (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.fifo_read_err (addr=0xcd0be9d8) == 0x1
          UVM_INFO @ 10023192763 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---
          
          

        ... and 10 more failures.

UVM_ERROR (cip_base_scoreboard.sv:242) [scoreboard] Check failed expected_alert[alert_name].expected == * (* [*] vs * [*]) alert fatal_alert triggered unexpectedly has 10 failures:
    Test entropy_src_fw_ov has 10 failures.

        10.entropy_src_fw_ov.53338546369351147830339278103602407665931745096215236339986154916652301624437
        Line 201, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/10.entropy_src_fw_ov/latest/run.log

          UVM_ERROR @ 2174578862 ps: (cip_base_scoreboard.sv:242) [uvm_test_top.env.scoreboard] Check failed expected_alert[alert_name].expected == 1 (0 [0x0] vs 1 [0x1]) alert fatal_alert triggered unexpectedly
          UVM_INFO @ 2174578862 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---
          
          

        84.entropy_src_fw_ov.33398070227105552121013533372439818982363524859982799627376649773259324104411
        Line 201, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/84.entropy_src_fw_ov/latest/run.log

          UVM_ERROR @ 1874498399 ps: (cip_base_scoreboard.sv:242) [uvm_test_top.env.scoreboard] Check failed expected_alert[alert_name].expected == 1 (0 [0x0] vs 1 [0x1]) alert fatal_alert triggered unexpectedly
          UVM_INFO @ 1874498399 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---
          
          

        ... and 8 more failures.

UVM_FATAL (entropy_src_base_vseq.sv:448) [entropy_src_rng_vseq] Timeout encountered while reading TlSrcObserveFIFO has 10 failures:
    Test entropy_src_rng_max_rate has 10 failures.

        50.entropy_src_rng_max_rate.13537851687682562004826217509152345127253678253750537256650118267539658573952
        Line 3602, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/50.entropy_src_rng_max_rate/latest/run.log

          UVM_FATAL @ 8023885429 ps: (entropy_src_base_vseq.sv:448) [uvm_test_top.env.virtual_sequencer.entropy_src_rng_vseq] Timeout encountered while reading TlSrcObserveFIFO
          UVM_INFO @ 8023885429 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---
          
          

        79.entropy_src_rng_max_rate.5028339047366192533005395446779632652250658494442617748780476099867966463351
        Line 552, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/79.entropy_src_rng_max_rate/latest/run.log

          UVM_FATAL @ 1646322146 ps: (entropy_src_base_vseq.sv:448) [uvm_test_top.env.virtual_sequencer.entropy_src_rng_vseq] Timeout encountered while reading TlSrcObserveFIFO
          UVM_INFO @ 1646322146 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---
          
          

        ... and 8 more failures.

xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_entropy_src_*/rtl/entropy_src_core.sv,3387): Assertion Final_PreconFifoPushedPostStartup_A has failed has 8 failures:
    Test entropy_src_intr has 8 failures.

        1.entropy_src_intr.76996431287204279455894590583311329705209531540673924611444955187481959631416
        Line 197, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/1.entropy_src_intr/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_entropy_src_0.1/rtl/entropy_src_core.sv,3387): (time 3288948348 PS) Assertion tb.dut.u_entropy_src_core.Final_PreconFifoPushedPostStartup_A has failed
          xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
          xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
          xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
          xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.

        5.entropy_src_intr.81399488564668519789761175947726660564880861318935623662116753382313024323753
        Line 197, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/5.entropy_src_intr/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_entropy_src_0.1/rtl/entropy_src_core.sv,3387): (time 519930836 PS) Assertion tb.dut.u_entropy_src_core.Final_PreconFifoPushedPostStartup_A has failed
          xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
          xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
          xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
          xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.

        ... and 6 more failures.

UVM_FATAL (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.sfifo_observe_err (addr=*) == * has 6 failures:
    Test entropy_src_functional_errors has 6 failures.

        157.entropy_src_functional_errors.76266914566011573609946664847937347413630891835481572094638268175040397167436
        Line 154, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/157.entropy_src_functional_errors/latest/run.log

          UVM_FATAL @ 10015606517 ps: (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.sfifo_observe_err (addr=0x7cbd1bd8) == 0x1
          UVM_INFO @ 10015606517 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---
          
          

        200.entropy_src_functional_errors.107459823635817182597659047661069327453872246314043228732067453704369594874200
        Line 154, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/200.entropy_src_functional_errors/latest/run.log

          UVM_FATAL @ 10014776315 ps: (csr_utils_pkg.sv:577) [csr_utils::csr_spinwait] timeout entropy_src_reg_block.err_code.sfifo_observe_err (addr=0xc5b7d3d8) == 0x1
          UVM_INFO @ 10014776315 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---
          
          

        ... and 4 more failures.

xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_sha3_*/rtl/sha*.sv,505): Assertion KeccakIdleWhenNoRunHs_A has failed has 5 failures:
    Test entropy_src_rng_max_rate has 3 failures.

        30.entropy_src_rng_max_rate.43669038798347356606364372477386891708842464154482743953462961253191007312812
        Line 5292, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/30.entropy_src_rng_max_rate/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_sha3_0.1/rtl/sha3.sv,505): (time 10081509392 PS) Assertion tb.dut.u_entropy_src_core.u_sha3.KeccakIdleWhenNoRunHs_A has failed
          UVM_ERROR @ 10081509392 ps: (sha3.sv:505) [ASSERT FAILED] KeccakIdleWhenNoRunHs_A
          UVM_INFO @ 10081509392 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---
          

        35.entropy_src_rng_max_rate.38226058601310527602372740902750344178510062677579296096546915538882673727117
        Line 5044, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/35.entropy_src_rng_max_rate/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_sha3_0.1/rtl/sha3.sv,505): (time 10000255942 PS) Assertion tb.dut.u_entropy_src_core.u_sha3.KeccakIdleWhenNoRunHs_A has failed
          UVM_ERROR @ 10000255942 ps: (sha3.sv:505) [ASSERT FAILED] KeccakIdleWhenNoRunHs_A
          UVM_INFO @ 10000255942 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---
          

        ... and 1 more failures.
    Test entropy_src_rng has 2 failures.

        206.entropy_src_rng.103095858364156404689733577356642794893420902795832583750447299445026962054591
        Line 2132, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/206.entropy_src_rng/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_sha3_0.1/rtl/sha3.sv,505): (time 10006457971 PS) Assertion tb.dut.u_entropy_src_core.u_sha3.KeccakIdleWhenNoRunHs_A has failed
          UVM_ERROR @ 10006457971 ps: (sha3.sv:505) [ASSERT FAILED] KeccakIdleWhenNoRunHs_A
          UVM_INFO @ 10006457971 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---
          

        277.entropy_src_rng.10218765318577669684772589837900679687457166425146218520160727932628675371732
        Line 3376, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/277.entropy_src_rng/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_sha3_0.1/rtl/sha3.sv,505): (time 10073990988 PS) Assertion tb.dut.u_entropy_src_core.u_sha3.KeccakIdleWhenNoRunHs_A has failed
          UVM_ERROR @ 10073990988 ps: (sha3.sv:505) [ASSERT FAILED] KeccakIdleWhenNoRunHs_A
          UVM_INFO @ 10073990988 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---

xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_entropy_src_*/rtl/entropy_src_core.sv,3375): Assertion Final_EsfinalFifoPushedPostStartup_A has failed has 1 failures:
    Test entropy_src_rng_max_rate has 1 failures.

        29.entropy_src_rng_max_rate.103372143814982320608707777089551149521646032684346793570205595087258379627791
        Line 4341, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/29.entropy_src_rng_max_rate/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_entropy_src_0.1/rtl/entropy_src_core.sv,3375): (time 10059111208 PS) Assertion tb.dut.u_entropy_src_core.Final_EsfinalFifoPushedPostStartup_A has failed
          xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
          xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
          xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.
          xmsim: *W,SLFINV: Call to process::self() from invalid process; returning null.

xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_entropy_src_*/rtl/entropy_src_core.sv,3163): Assertion AtReset_EsbitFifoPushedIntoPosthtFifo_A has failed has 1 failures:
    Test entropy_src_fw_ov has 1 failures.

        170.entropy_src_fw_ov.52615235015724664584965654782282422443413719510715433637996484048496250602052
        Line 680, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/170.entropy_src_fw_ov/latest/run.log

          xmsim: *E,ASRTST (/home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/default/src/lowrisc_ip_entropy_src_0.1/rtl/entropy_src_core.sv,3163): (time 4187403697 PS) Assertion tb.dut.u_entropy_src_core.AtReset_EsbitFifoPushedIntoPosthtFifo_A has failed
          UVM_ERROR @ 4187403697 ps: (entropy_src_core.sv:3163) [ASSERT FAILED] AtReset_EsbitFifoPushedIntoPosthtFifo_A
          UVM_INFO @ 4187403697 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---

UVM_ERROR (cip_base_scoreboard.sv:302) scoreboard [scoreboard] alert recov_alert did not trigger max_delay:* has 1 failures:
    Test entropy_src_rng_max_rate has 1 failures.

        296.entropy_src_rng_max_rate.18141511378691529040367643777542872286800865523148623787758567428344086013439
        Line 307, in log /home/dev/src/scratch/HEAD/entropy_src-sim-xcelium/296.entropy_src_rng_max_rate/latest/run.log

          UVM_ERROR @ 547476028 ps: (cip_base_scoreboard.sv:302) uvm_test_top.env.scoreboard [uvm_test_top.env.scoreboard] alert recov_alert did not trigger max_delay:5
          UVM_INFO @ 547476028 ps: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
          --- UVM Report catcher Summary ---

@vogelpi vogelpi mentioned this pull request Mar 18, 2024
Closed
10 tasks
@vogelpi
[entropy_src] Reduce depth of Observe FIFO
4139ed6 
Halving the depth of the observe FIFO allows saving 1024 FFs. With a
FIFO size of 1 kbit, it is still possible to buffer a full, contiguous
1024-sample window in single-channel mode. For the multi-channel mode,
an experiment on the engineering sample showed that Ibex is fast enough
in reading out the FIFO to avoid it overflowing during read out.

Signed-off-by: Pirmin Vogel <[email protected]>
andreaskurth
andreaskurth approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@andreaskurth andreaskurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work, @vogelpi, which LGTM!

I have a minor comment on a SW constant, which this PR changed, but that can be resolved later.

@andreaskurth
Copy link
Contributor

This PR has passed CI checks; the two failures in kokoro (license warning) and in-depth lint (known lint problem in AST) are unrelated to this PR. Merging.

@andreaskurth andreaskurth merged commit 54661e6 into lowRISC:master Mar 19, 2024
29 of 32 checks passed
@vogelpi vogelpi deleted the es-observe-fifo-depth branch March 19, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskurth andreaskurth andreaskurth approved these changes

@msfschaffner msfschaffner msfschaffner approved these changes

@h-filali h-filali Awaiting requested review from h-filali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vogelpi @msfschaffner @andreaskurth @h-filali