[usb,aon_wake] Report 'bus not idle' status to usbdev #22019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alees24
requested review from
rswarbrick
and removed request for
a team,
msfschaffner and
rswarbrick
alees24
force-pushed
the
usb-aon-not-idle
branch
from
8c819a6
to
d254749
Compare
The 'bus not idle' condition had to be inferred by software, from the absence of Bus Reset and Disconnect indications; less than ideal from a robustness perspective even when returning from Deep Sleep, but it afforded no opportunity to indicate a non-idle bus state whilst still suspending/entering sleep. Introduce an explicit indication for increased robustness and error recovery. Signed-off-by: Adrian Lees <[email protected]>
alees24
force-pushed
the
usb-aon-not-idle
branch
from
d254749
to
c0e44a8
Compare
pamaury
approved these changes
Mar 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'bus not idle' condition had to be inferred by software, from the absence of Bus Reset and Disconnect indications; less than ideal from a robustness perspective even when returning from Deep Sleep, but it afforded no opportunity to indicate a non-idle bus state whilst still suspending/entering sleep. Introduce an explicit indication for increased robustness and error recovery.
This has been separated out from PR #19270 because of the more contentious, still-to-be-resolved change to pull up behavior and handover sequencing in that PR.