[rom] remove 64k ROM_EXT code size restriction #21831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothytrippel
requested review from
jwnrt,
jon-flatley,
cfrantz and
moidx
and removed request for
a team,
jwnrt and
jon-flatley
cfrantz
approved these changes
Mar 5, 2024
pamaury
reviewed
Mar 5, 2024
moidx
approved these changes
Mar 6, 2024
timothytrippel
force-pushed
the
remove-64k-limit
branch
3 times, most recently
from
0976edb
to
89635cf
Compare
This fixes lowRISC#21553. Note, this simply removes the restriction. Additional changes will be required to truly support dynamic ROM_EXT / Owner slot sizes (if that is deemed desirable in the future). Signed-off-by: Tim Trippel <[email protected]>
This tests the ability to load a ROM_EXT image that is larger than the 64k ROM_EXT slot to facilitate provisioning flows. Signed-off-by: Tim Trippel <[email protected]>
timothytrippel
force-pushed
the
remove-64k-limit
branch
from
89635cf
to
0a26aac
Compare
timothytrippel
changed the title
Signed-off-by: Tim Trippel <[email protected]>
timothytrippel
added a commit
to timothytrippel/opentitan
that referenced
this pull request
Mar 8, 2024
Since the merging of lowRISC#21831, larger binaries can now be placed in the ROM_EXT bootstage. This enables combining the perso binaries into a single binary, starting by combining binary 1 & 2. Signed-off-by: Tim Trippel <[email protected]>
This was referenced Mar 8, 2024
timothytrippel
added a commit
to timothytrippel/opentitan
that referenced
this pull request
Mar 10, 2024
Since the merging of lowRISC#21831, larger binaries can now be placed in the ROM_EXT bootstage. This enables combining the perso binaries into a single binary, starting by combining binary 1 & 2. Signed-off-by: Tim Trippel <[email protected]>
timothytrippel
added a commit
that referenced
this pull request
Mar 11, 2024
Since the merging of #21831, larger binaries can now be placed in the ROM_EXT bootstage. This enables combining the perso binaries into a single binary, starting by combining binary 1 & 2. Signed-off-by: Tim Trippel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #21553.
Note, this simply removes the restriction. Additional changes will be required to truly support dynamic ROM_EXT / Owner slot sizes (if that is deemed desirable in the future).