[lc_ctrl] Always allow transitions into scrap #21213
Conversation
msfschaffner
requested review from
vogelpi,
cdgori,
zi-v,
a-pronin and
johannheyszl
msfschaffner
requested review from
marnovandermaas and
andreaskurth
and removed request for
a team,
a-pronin and
marnovandermaas
msfschaffner
force-pushed
the
lc-always-scrap
branch
8 times, most recently
from
271c4c5
to
a3b0d33
Compare
msfschaffner
force-pushed
the
lc-always-scrap
branch
3 times, most recently
from
a955ec3
to
92adfbe
Compare
| if (trans_target_i == {DecLcStateNumRep{DecLcStScrap}}) begin | ||
| next_lc_cnt_o = LcCnt24; | ||
| next_lc_state_o = LcStScrap; | ||
| trans_cnt_oflw_error_o = 1'b0; |
There was a problem hiding this comment.
This is the main change. Please disregard DV for now - the error case modelling does not seem to work correctly yet.
There was a problem hiding this comment.
This looks good thanks @msfschaffner !
I wasn't sure if the version change / going back to D1/V1 is necessary for just this as it could also be considered as a bug fix. But given the other things following for M2, it seems appropriate. The RTL change itself looks good to me.
Yeah I changed it back since there will be another change coming that changes the interfaces (for RMA ack). |
Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner
force-pushed
the
lc-always-scrap
branch
from
92adfbe
to
886a3ca
Compare
msfschaffner
force-pushed
the
lc-always-scrap
branch
2 times, most recently
from
19240f0
to
8607586
Compare
We should always allow transitions into scrap, no matter whether the transition counter is maxed out or not. In order to prevent any abuse of this unconditional transition path, we max out the counter and program the LC state to SCRAP already in the transition counter increment phase instead of programming the counter state and LC state separately in two phases as all other transitions. This fixes lowRISC#13617. Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner
force-pushed
the
lc-always-scrap
branch
from
8607586
to
2851c4f
Compare
|
Ok the latest force push includes fixes to the DV env. We basically have to change two things:
@jdonjdon @matutem @rswarbrick would be great if you could take a look at the DV changes. |
|
I am moving this in to unblock other work - if there is anything I should amend on the DV side please let me know. |
We should always allow transitions into scrap, no matter whether the transition counter is maxed out or not.
In order to prevent any abuse of this unconditional transition path, we max out the counter and program the LC state to SCRAP already in the transition counter increment phase instead of programming the counter state and LC state separately in two phases as all other transitions.
This fixes #13617.