[bazel] Create a static library link rule #21198
Conversation
| name = "otcrypto", | ||
| hdrs = [ | ||
| "otcrypto.h", |
There was a problem hiding this comment.
Can we now delete this header file, or is it still useful? The purpose was to give callers the ability to import the entire cryptolib with one import rather than revealing the internal structure.
There was a problem hiding this comment.
We can keep it if you feel it better serves the customer.
As discussed offline, we'll have to determine what a release of cryptolib looks like to downstream customers and possibly consider packaging the library archive and headers as a release artifact. We can tackle that work when we understand how a downstream customer will want to incorporate cryptolib into their project.
There was a problem hiding this comment.
Output is named ./bazel-bin/sw/device/lib/crypto/otcrypto.a instead of libotcrypto.a
Bazel currently does not have a rule which can emit a static library suitable as a release artifact. Adapt one of the implementations discussed in the bazel community to our needs. Signed-off-by: Chris Frantz <[email protected]>
cfrantz
added
the
CherryPick:earlgrey_es_sival
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin earlgrey_es_sival
git worktree add -d .worktree/backport-21198-to-earlgrey_es_sival origin/earlgrey_es_sival
cd .worktree/backport-21198-to-earlgrey_es_sival
git switch --create backport-21198-to-earlgrey_es_sival
git cherry-pick -x 86a935fe2e77b96e374642a64f816f943d921739 |
|
This rule produce |
Bazel currently does not have a rule which can emit a static library suitable as a release artifact. Adapt one of the implementations discussed in the bazel community to our needs.