Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Address @bitstreams//BUILD.bazel nullifying action cache #20307

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

a-will
Copy link
Contributor

@a-will a-will commented Nov 10, 2023

Place bitstreams from other jobs in a consistent location, so the BUILD.bazel file and the command line for the action are not needlessly changed for every CI run.

Originally, the git revision would be part of the path name to source files, and this precluded any possibility of getting a hit to the action cache.

Place bitstreams from other jobs in a consistent location, so the
BUILD.bazel file and the command line for the action are not needlessly
changed for every CI run.

Originally, the git revision would be part of the path name to source
files, and this precluded any possibility of getting a hit to the action
cache.

Signed-off-by: Alexander Williams <[email protected]>
@a-will a-will requested a review from pamaury November 10, 2023 02:29
@a-will
Copy link
Contributor Author

a-will commented Nov 10, 2023

We're still building new bitstreams way too often, but this will hopefully enable some cache hits (when we manage to actually hit the cached-bitstream path).

Copy link
Contributor

@pamaury pamaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @a-will , this looks good to me. After this goes through, I will try to investigate things more with aquery and see if we can log the cache hits/miss.

@a-will a-will marked this pull request as ready for review November 10, 2023 06:02
@a-will a-will requested a review from rswarbrick as a code owner November 10, 2023 06:02
@a-will a-will merged commit 45e9591 into lowRISC:master Nov 10, 2023
29 checks passed
@a-will a-will deleted the ci-use-consistent-cache-dirs branch November 10, 2023 06:02
@jwnrt
Copy link
Contributor

jwnrt commented Nov 10, 2023

CC @nbdd0121 who's interested in bitstream caching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants