Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pwrmgr,ipgen] Convert pwrmgr to ipgen #19801

Merged
merged 15 commits into from
Oct 9, 2023
Merged

[pwrmgr,ipgen] Convert pwrmgr to ipgen #19801

merged 15 commits into from
Oct 9, 2023

Commits on Oct 5, 2023

  1. [util,topgen] Clean some of the code 

    This has no functional changes.
Format the code with lintpy.
Simplify some path handling.
Add more typing in function declarations.

Signed-off-by: Guillermo Maturana <[email protected]>
    @matutem
    matutem committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    4cc8f96 View commit details
    Browse the repository at this point in the history

  2. [util,ipgen] Minor fix in error message 

    Signed-off-by: Guillermo Maturana <[email protected]>
    @matutem
    matutem committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    979b217 View commit details
    Browse the repository at this point in the history

  3. [ip_templates,hjson] Remove clutter 

    Remove redundant commas and quotes.

Signed-off-by: Guillermo Maturana <[email protected]>
    @matutem
    matutem committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    1632a05 View commit details
    Browse the repository at this point in the history

  4. [pwrmge,ip_gen] Add tpldesc hjson file 

    Populate the default for object parameters with representative data.
Ideally these should have an associated validator function.

Signed-off-by: Guillermo Maturana <[email protected]>
    @matutem
    matutem committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    8c151d7 View commit details
    Browse the repository at this point in the history

  5. [pwrmgr,ipgen] Copy all hw/ip/pwrmgr files to ip_templates 

    This is a straight copy with no changes to the files.

Signed-off-by: Guillermo Maturana <[email protected]>
    @matutem
    matutem committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    16498ce View commit details
    Browse the repository at this point in the history

  6. [pwrmgr,ipgen] Turn a few more files into templates 

    The files are almost identical to the previous ones, except they use
${top_name} instead of a specific name and consecutive '#' are escaped
so they are not considered md comments. This escape replaces things like
`###` by `${"###"}`.

Signed-off-by: Guillermo Maturana <[email protected]>
    @matutem
    matutem committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ccf55ca View commit details
    Browse the repository at this point in the history

  7. [pwrmgr,ipgen] Generate pwrmgr ip_autogen files with topgen 

    This changes topgen.py to generate pwrmgr using ipgen instead of the former
way. The old hw/<top>/ip/pwrmgr files are no longer created by topgen.
Other than the change in topgen.py, all new files are just a side-effect
of running `make -C hw`.

Signed-off-by: Guillermo Maturana <[email protected]>
    @matutem
    matutem committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c76540b View commit details
    Browse the repository at this point in the history

  8. [pwrmgr,ipgen] Fix BUILD files 

    Signed-off-by: Guillermo Maturana <[email protected]>
    @matutem
    matutem committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    765ed34 View commit details
    Browse the repository at this point in the history

  9. [pwrmgr,ipgen] Fix pwrmgr template and autogen core files 

    Signed-off-by: Guillermo Maturana <[email protected]>
    @matutem
    matutem committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    a365b66 View commit details
    Browse the repository at this point in the history

  10. [pwrmgr,ipgen] Fix hjson files 

    Signed-off-by: Guillermo Maturana <[email protected]>
    @matutem
    matutem committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    20d91d3 View commit details
    Browse the repository at this point in the history

  11. [pwrmgr,ipgen] Fix link in non-generated dif header 

    Signed-off-by: Guillermo Maturana <[email protected]>
    @matutem
    matutem committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    a310db7 View commit details
    Browse the repository at this point in the history

  12. [pwrmgr,ipgen] Fix paths in verible allowlist 

    Signed-off-by: Guillermo Maturana <[email protected]>
    @matutem
    matutem committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    af4f990 View commit details
    Browse the repository at this point in the history

  13. [pwrmgr,ipgen] Fix documentation collateral 

    Signed-off-by: Guillermo Maturana <[email protected]>
    @matutem
    matutem committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    2a00ef0 View commit details
    Browse the repository at this point in the history

  14. [pwrmgr,ipgen] Remove the hw/ip/pwrmgr and their autogen files 

    Signed-off-by: Guillermo Maturana <[email protected]>
    @matutem
    matutem committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ad26929 View commit details
    Browse the repository at this point in the history

  15. [pwrmgr,ipgen] Fix top_englishbreakfast build 

    Signed-off-by: Guillermo Maturana <[email protected]>
    @matutem
    matutem committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    93e2f6d View commit details
    Browse the repository at this point in the history