Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sram_ctrl] Fix alert signaling for Readback feature #24698

Closed
vogelpi opened this issue Sep 30, 2024 · 0 comments · Fixed by #24679
Closed

[sram_ctrl] Fix alert signaling for Readback feature #24698

vogelpi opened this issue Sep 30, 2024 · 0 comments · Fixed by #24679
Assignees
@nasahlpa
Labels
ECO Accepted as an ECO IP:sram_ctrl Type:Bug Bugs

Comments

@vogelpi
Copy link
Contributor

vogelpi commented Sep 30, 2024

Description

While taking care of #23322, @nasahlpa discovered that under some circumstances, readback errors don't get signaled as alerts, meaning they get remain unnoticed which is bad.
@vogelpi vogelpi added Type:Bug Bugs IP:sram_ctrl ECO Accepted as an ECO labels Sep 30, 2024
nasahlpa added a commit to nasahlpa/opentitan that referenced this issue Sep 30, 2024
@nasahlpa
[tlul/rtl] Modify readback check error reporting logic
73e8258 
Currently, only a readback error check is reported when the `error_i`
signal is not raised. However, as this signal is also raised when there
is no activity on the TL-UL bus, we might miss some readback failures.

This commit modifies the error reporting logic to also report the
readback mismatch when the error signal is raised.

Closes lowRISC#24698.

Signed-off-by: Pascal Nasahl <[email protected]>
@nasahlpa nasahlpa mentioned this issue Sep 30, 2024
Merged
vogelpi pushed a commit to vogelpi/opentitan that referenced this issue Sep 30, 2024
@nasahlpa @vogelpi
[tlul/rtl] Modify readback check error reporting logic
b42bd24 
Currently, only a readback error check is reported when the `error_i`
signal is not raised. However, as this signal is also raised when there
is no activity on the TL-UL bus, we might miss some readback failures.

This commit modifies the error reporting logic to also report the
readback mismatch when the error signal is raised.

Closes lowRISC#24698.

This is a cherry pick of commit 267e61c
to branch earlgrey_1.0.0.

Signed-off-by: Pascal Nasahl <[email protected]>
@vogelpi vogelpi mentioned this issue Sep 30, 2024
Merged
venkatk-ot pushed a commit to venkatk-ot/opentitan that referenced this issue Oct 1, 2024
@nasahlpa @venkatk-ot
[tlul/rtl] Modify readback check error reporting logic
718f28b 
Currently, only a readback error check is reported when the `error_i`
signal is not raised. However, as this signal is also raised when there
is no activity on the TL-UL bus, we might miss some readback failures.

This commit modifies the error reporting logic to also report the
readback mismatch when the error signal is raised.

Closes lowRISC#24698.

Signed-off-by: Pascal Nasahl <[email protected]>
vogelpi pushed a commit that referenced this issue Oct 1, 2024
@nasahlpa @vogelpi
[tlul/rtl] Modify readback check error reporting logic
40292c0 
Currently, only a readback error check is reported when the `error_i`
signal is not raised. However, as this signal is also raised when there
is no activity on the TL-UL bus, we might miss some readback failures.

This commit modifies the error reporting logic to also report the
readback mismatch when the error signal is raised.

Closes #24698.

This is a cherry pick of commit 267e61c
to branch earlgrey_1.0.0.

Signed-off-by: Pascal Nasahl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nasahlpa nasahlpa

Labels
ECO Accepted as an ECO IP:sram_ctrl Type:Bug Bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tlul,rtl] Modify readback check error reporting logic nasahlpa/opentitan
2 participants
@nasahlpa @vogelpi