Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kmac,dv] Verify fifo_empty status interrupt #22341

Closed
andreaskurth opened this issue Mar 29, 2024 · 5 comments
Closed

[kmac,dv] Verify fifo_empty status interrupt #22341

andreaskurth opened this issue Mar 29, 2024 · 5 comments
Assignees
@martin-velay
Labels
Component:DV DV issue: testbench, test case, etc. IP:kmac
Milestone
Earlgrey-PROD.M7

Comments

@andreaskurth
Copy link
Contributor

In PR #21657 we changed the fifo_empty interrupt from event to status. kmac_scoreboard currently doesn't model and check that interrupt; we should correct that.
@andreaskurth andreaskurth added Component:DV DV issue: testbench, test case, etc. IP:kmac labels Mar 29, 2024
@andreaskurth andreaskurth added this to the Earlgrey-PROD.M4 milestone Mar 29, 2024
@andreaskurth andreaskurth mentioned this issue Mar 29, 2024
Closed
@vogelpi
Copy link
Contributor

vogelpi commented May 6, 2024

Software is currently not using the fifo_empty interrupt and we may thus want to consider de-prioritizing this task @andreaskurth .

@vogelpi vogelpi added the Triage: deprioritize? temporary label for triage; issue could be deprioritized label May 6, 2024
@andreaskurth
Copy link
Contributor Author

Discussed in triage: same as for the similar HMAC issue, we move this to M5

@vogelpi vogelpi removed the Triage: deprioritize? temporary label for triage; issue could be deprioritized label May 24, 2024
@martin-velay martin-velay mentioned this issue Jun 6, 2024
Closed
@vogelpi
Copy link
Contributor

vogelpi commented Jun 18, 2024

This would be good to get. Maybe something for @martin-velay after taking care of the same task for HMAC?

martin-velay added a commit to martin-velay/opentitan that referenced this issue Jul 5, 2024
@martin-velay
[kmac,dv] Check FIFO empty interrupt
1708f9a 
  - Linked to this issue lowRISC#22341

Signed-off-by: Martin Velay <[email protected]>
@martin-velay martin-velay mentioned this issue Jul 5, 2024
Merged
martin-velay added a commit to martin-velay/opentitan that referenced this issue Jul 9, 2024
@martin-velay
[kmac,dv] Check FIFO empty interrupt
d777849 
  - Linked to this issue lowRISC#22341

Signed-off-by: Martin Velay <[email protected]>
martin-velay added a commit to martin-velay/opentitan that referenced this issue Jul 9, 2024
@martin-velay
[kmac,dv] Check FIFO empty interrupt
f1560b6 
  - Linked to this issue lowRISC#22341

Signed-off-by: Martin Velay <[email protected]>
@vogelpi
Copy link
Contributor

vogelpi commented Jul 12, 2024

@martin-velay started working on this and has a first draft PR ready here: #23942. Unfortunately, the work is not yet finished and Martin was OoO this week. Since this issue isn't super critical (see previous comments), I am moving this to M7 now.

martin-velay added a commit to martin-velay/opentitan that referenced this issue Jul 19, 2024
@martin-velay
[kmac,dv] Check FIFO empty interrupt
07c38bd 
  - Linked to this issue lowRISC#22341
  - fix issues with Xcelium

Signed-off-by: Martin Velay <[email protected]>
martin-velay added a commit to martin-velay/opentitan that referenced this issue Jul 22, 2024
@martin-velay
[kmac,dv] Check FIFO empty interrupt
ff69282 
  - Linked to this issue lowRISC#22341
  - fix issues with Xcelium

Signed-off-by: Martin Velay <[email protected]>
martin-velay added a commit to martin-velay/opentitan that referenced this issue Jul 22, 2024
@martin-velay
[kmac,dv] Check FIFO empty interrupt
2b700a8 
  - Linked to this issue lowRISC#22341
  - fix issues with Xcelium

Signed-off-by: Martin Velay <[email protected]>
martin-velay added a commit to martin-velay/opentitan that referenced this issue Jul 22, 2024
@martin-velay
[kmac,dv] Check FIFO empty interrupt
d51f841 
  - Linked to this issue lowRISC#22341

Signed-off-by: Martin Velay <[email protected]>
martin-velay added a commit to martin-velay/opentitan that referenced this issue Jul 24, 2024
@martin-velay
[kmac,dv] Check FIFO empty interrupt
1a5ab4b 
  - Linked to this issue lowRISC#22341

Signed-off-by: Martin Velay <[email protected]>
rswarbrick pushed a commit that referenced this issue Jul 27, 2024
@martin-velay @rswarbrick
[kmac,dv] Check FIFO empty interrupt
58db0f0 
  - Linked to this issue #22341

Signed-off-by: Martin Velay <[email protected]>
@martin-velay
Copy link
Contributor

Closed as #23942 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-velay martin-velay

Labels
Component:DV DV issue: testbench, test case, etc. IP:kmac
Projects
None yet
Milestone
Earlgrey-PROD.M7
Development

No branches or pull requests
3 participants
@andreaskurth @vogelpi @martin-velay