Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[entropy_src] Backpressure handling follow-up work #21855

Closed
4 tasks done
vogelpi opened this issue Mar 6, 2024 · 1 comment · Fixed by #23893
Closed
4 tasks done

[entropy_src] Backpressure handling follow-up work #21855

vogelpi opened this issue Mar 6, 2024 · 1 comment · Fixed by #23893
Assignees
@vogelpi
Labels
Component:Doc Documentation issue Component:DV DV issue: testbench, test case, etc. Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:entropy_src Subsystem:Entropy entropy_src, csrng, or edn related issues
Milestone
Earlgrey-PROD.M5

Comments

@vogelpi
Copy link
Contributor

vogelpi commented Mar 6, 2024 •
edited
Loading

Description

What is left from #21799 for after M2:
@vogelpi vogelpi added Component:Doc Documentation issue Component:DV DV issue: testbench, test case, etc. Subsystem:Entropy entropy_src, csrng, or edn related issues IP:entropy_src labels Mar 6, 2024
@vogelpi vogelpi added this to the Darjeeling-ES: M4 milestone Mar 6, 2024
@vogelpi vogelpi self-assigned this Mar 6, 2024
@vogelpi vogelpi added the Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones label Mar 6, 2024
vogelpi added a commit to vogelpi/opentitan that referenced this issue Mar 28, 2024
@vogelpi
[entropy_src/doc] Document distribution FIFO
7f101ec 
This is related to lowRISC#21855.

Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit to vogelpi/opentitan that referenced this issue Mar 29, 2024
@vogelpi
[entropy_src/doc] Document distribution FIFO
72b7839 
This is related to lowRISC#21855.

Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit to vogelpi/opentitan that referenced this issue Mar 29, 2024
@vogelpi
[entropy_src/doc] Document distribution FIFO
d58cffc 
This is related to lowRISC#21855.

Signed-off-by: Pirmin Vogel <[email protected]>
This was referenced Mar 29, 2024
Closed
Closed
vogelpi added a commit to vogelpi/opentitan that referenced this issue Mar 29, 2024
@vogelpi
[entropy_src/doc] Document distribution FIFO
76256cb 
This is related to lowRISC#21855.

Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit to vogelpi/opentitan that referenced this issue Mar 29, 2024
@vogelpi
[entropy_src/doc] Document distribution FIFO
0cb2bcc 
This is related to lowRISC#21855.

Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit that referenced this issue Mar 29, 2024
@vogelpi
[entropy_src/doc] Document distribution FIFO
8e89f30 
This is related to #21855.

Signed-off-by: Pirmin Vogel <[email protected]>
@vogelpi
Copy link
Contributor Author

vogelpi commented Jun 18, 2024

We should do this for M5. Discussed with @h-filali that this one of the next things to investigate after coverage closure.

IIRC, I've only noted test failures due to backpressure in the rng_max_rate test.

vogelpi added a commit to vogelpi/opentitan that referenced this issue Jul 1, 2024
@vogelpi
[chip-test/sival] Check ENTRORPY_SRC_POSTHT_ENTROPY_DROP_ALERT_BIT
c250ff3 
When running in Firmware Override: Observe mode, this bit should be
checked. If it's asserted, this means that health tested entropy bits
have been dropped before the postht FIFO due to conditioner back
pressure. This means entropy observed via observe FIFO may be
non-contiguous.

This is related to lowRISC#21855.

Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit to vogelpi/opentitan that referenced this issue Jul 1, 2024
@vogelpi
[chip-test/sival] Check ENTRORPY_SRC_POSTHT_ENTROPY_DROP_ALERT_BIT
a79ecba 
When running in Firmware Override: Observe mode, this bit should be
checked. If it's asserted, this means that health tested entropy bits
have been dropped before the postht FIFO due to conditioner back
pressure. This means entropy observed via observe FIFO may be
non-contiguous.

This is related to lowRISC#21855.

Signed-off-by: Pirmin Vogel <[email protected]>
@vogelpi vogelpi mentioned this issue Jul 1, 2024
Merged
vogelpi added a commit to vogelpi/opentitan that referenced this issue Jul 1, 2024
@vogelpi
[entropy_src] Add SVA to ensure FIFOs are empty when triggering SHA
a8a3b01 
If any of the postht, distr or precon FIFOs are non-empty when
triggering the conditioner, there is risk of leaving entropy bits tested
as part of the current window inside the pipeline instead of absorbing
them into the current seed. This would be problematic.

This is related to lowRISC#21855.

Signed-off-by: Pirmin Vogel <[email protected]>
@vogelpi vogelpi mentioned this issue Jul 1, 2024
Merged
vogelpi added a commit that referenced this issue Jul 2, 2024
@vogelpi
[chip-test/sival] Check ENTRORPY_SRC_POSTHT_ENTROPY_DROP_ALERT_BIT
5f847e3 
When running in Firmware Override: Observe mode, this bit should be
checked. If it's asserted, this means that health tested entropy bits
have been dropped before the postht FIFO due to conditioner back
pressure. This means entropy observed via observe FIFO may be
non-contiguous.

This is related to #21855.

Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit to vogelpi/opentitan that referenced this issue Jul 2, 2024
@vogelpi
[entropy_src] Add SVA to ensure FIFOs are empty when triggering SHA
0a2cfe0 
If any of the postht, distr or precon FIFOs are non-empty when
triggering the conditioner, there is risk of leaving entropy bits tested
as part of the current window inside the pipeline instead of absorbing
them into the current seed. This would be problematic.

This is related to lowRISC#21855.

Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit that referenced this issue Jul 2, 2024
@vogelpi
[entropy_src] Add SVA to ensure FIFOs are empty when triggering SHA
5784189 
If any of the postht, distr or precon FIFOs are non-empty when
triggering the conditioner, there is risk of leaving entropy bits tested
as part of the current window inside the pipeline instead of absorbing
them into the current seed. This would be problematic.

This is related to #21855.

Signed-off-by: Pirmin Vogel <[email protected]>
@vogelpi vogelpi mentioned this issue Jul 2, 2024
Merged
@vogelpi vogelpi mentioned this issue Jul 4, 2024
Closed
AlexJones0 pushed a commit to AlexJones0/opentitan that referenced this issue Jul 8, 2024
@vogelpi @AlexJones0
[chip-test/sival] Check ENTRORPY_SRC_POSTHT_ENTROPY_DROP_ALERT_BIT
3d72f08 
When running in Firmware Override: Observe mode, this bit should be
checked. If it's asserted, this means that health tested entropy bits
have been dropped before the postht FIFO due to conditioner back
pressure. This means entropy observed via observe FIFO may be
non-contiguous.

This is related to lowRISC#21855.

Signed-off-by: Pirmin Vogel <[email protected]>
AlexJones0 pushed a commit to AlexJones0/opentitan that referenced this issue Jul 8, 2024
@vogelpi @AlexJones0
[entropy_src] Add SVA to ensure FIFOs are empty when triggering SHA
b3ec1e3 
If any of the postht, distr or precon FIFOs are non-empty when
triggering the conditioner, there is risk of leaving entropy bits tested
as part of the current window inside the pipeline instead of absorbing
them into the current seed. This would be problematic.

This is related to lowRISC#21855.

Signed-off-by: Pirmin Vogel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vogelpi vogelpi

Labels
Component:Doc Documentation issue Component:DV DV issue: testbench, test case, etc. Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:entropy_src Subsystem:Entropy entropy_src, csrng, or edn related issues
Projects
None yet
Milestone
Earlgrey-PROD.M5
Development

Successfully merging a pull request may close this issue.

[entropy_src] Max rate test fixes vogelpi/opentitan
2 participants
@andreaskurth @vogelpi