Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chip-test] chip_sw_keymgr_key_derivation #21500

Closed
9 tasks
johngt opened this issue Feb 15, 2024 · 1 comment
Closed
9 tasks

[chip-test] chip_sw_keymgr_key_derivation #21500

johngt opened this issue Feb 15, 2024 · 1 comment
Assignees
@andrea-caforio
Labels
Component:ChipLevelTest Used to filter the chip-level test backlog IP:keymgr Priority:P2 Priority: medium SiVal:Autogen Generated by script
Milestone
Earlgrey ES SV3

Comments

@johngt
Copy link

johngt commented Feb 15, 2024

Test point name

chip_sw_keymgr_key_derivation

Host side component

Rust?

Opentitantool infrastructure implemented

Yes

Silicon Validation (SiVal)

Yes

Emulation targets

  • None
  • CW310
  • Hyperdebug + CW310

Contact person

Checklist

Please fill out this checklist as items are completed. Link to PRs and issues as appropriate.

  • Check if existing test covers most or all of this testpoint (if so, either extend said test to cover all points, or skip the next 3 checkboxes)
  • Device-side (C) component developed
  • Bazel build rules developed
  • Host-side component developed
  • Test added to dvsim nightly regression (and passing at time of checking)
  • For SiVal test cases, test is running relevant FPGA or silicon regression
@johngt johngt added Component:ChipLevelTest Used to filter the chip-level test backlog IP:keymgr Priority:P2 Priority: medium SiVal:Autogen Generated by script labels Feb 15, 2024
@andreaskurth andreaskurth mentioned this issue Mar 28, 2024
Closed
@moidx moidx added this to the Earlgrey ES SV3 milestone Apr 25, 2024
@andrea-caforio andrea-caforio self-assigned this Sep 30, 2024
andrea-caforio added a commit to andrea-caforio/opentitan that referenced this issue Oct 9, 2024
@andrea-caforio
[sival, keymgr] State-agnostic chip_sw_key_derivation_test
8312d23 
keymgr_key_derivation_test_fpga_cw310_sival_rom_ext test was marked as
broken in lowRISC#21706. This commit fixes this and addresses lowRISC#21500.

The source of the bug is due to the nature of the ROM_EXT that runs
through a CDI attestation flow advancing the key manager state to
"OwnerRootKey" in the process. This was not accounted for in the test,
which assumed an active CreatorRootKey" state (this works for sim_dv
tests but not with ROM_EXT). The solution to this issue lies in
rendering the test state-agnostic, meaning it will execute its
verifications independently of the current key manager state. This
approach thus mimics the keymgr_sideload_{aes,kmac,otbn} tests which
follow a similar strategy.

Signed-off-by: Andrea Caforio <[email protected]>
andrea-caforio added a commit to andrea-caforio/opentitan that referenced this issue Oct 9, 2024
@andrea-caforio
[sival, keymgr] State-agnostic chip_sw_key_derivation_test
c90a351 
keymgr_key_derivation_test_fpga_cw310_sival_rom_ext test was marked as
broken in lowRISC#21706. This commit fixes this and addresses lowRISC#21500.

The source of the bug is due to the nature of the ROM_EXT that runs
through a CDI attestation flow advancing the key manager state to
"OwnerRootKey" in the process. This was not accounted for in the test,
which assumed an active "CreatorRootKey" state (this works for sim_dv
tests but not with ROM_EXT). The solution to this issue lies in
rendering the test state-agnostic, meaning it will execute its
verifications independently of the current key manager state. This
approach thus mimics the keymgr_sideload_{aes,kmac,otbn} tests which
follow a similar strategy.

Signed-off-by: Andrea Caforio <[email protected]>
@andrea-caforio andrea-caforio mentioned this issue Oct 9, 2024
Merged
andrea-caforio added a commit to andrea-caforio/opentitan that referenced this issue Oct 9, 2024
@andrea-caforio
[sival, keymgr] State-agnostic chip_sw_key_derivation_test
68a488a 
keymgr_key_derivation_test_fpga_cw310_sival_rom_ext test was marked as
broken in lowRISC#21706. This commit fixes this and addresses lowRISC#21500.

The source of the bug is due to the nature of the ROM_EXT that runs
through a CDI attestation flow advancing the key manager state to
"OwnerRootKey" in the process. This was not accounted for in the test,
which assumed an active "CreatorRootKey" state (this works for sim_dv
tests but not with ROM_EXT). The solution to this issue lies in
rendering the test state-agnostic, meaning it will execute its
verifications independently of the current key manager state. This
approach thus mimics the keymgr_sideload_{aes,kmac,otbn} tests which
follow a similar strategy.

Signed-off-by: Andrea Caforio <[email protected]>
andrea-caforio added a commit to andrea-caforio/opentitan that referenced this issue Oct 9, 2024
@andrea-caforio
[sival, keymgr] State-agnostic chip_sw_key_derivation_test
7033770 
keymgr_key_derivation_test_fpga_cw310_sival_rom_ext test was marked as
broken in lowRISC#21706. This commit fixes this and addresses lowRISC#21500.

The source of the bug is due to the nature of the ROM_EXT that runs
through a CDI attestation flow advancing the key manager state to
"OwnerRootKey" in the process. This was not accounted for in the test,
which assumed an active "CreatorRootKey" state (this works for sim_dv
tests but not with ROM_EXT). The solution to this issue lies in
rendering the test state-agnostic, meaning it will execute its
verifications independently of the current key manager state. This
approach thus mimics the keymgr_sideload_{aes,kmac,otbn} tests which
follow a similar strategy.

Signed-off-by: Andrea Caforio <[email protected]>
andrea-caforio added a commit to andrea-caforio/opentitan that referenced this issue Oct 10, 2024
@andrea-caforio
[sival, keymgr] State-agnostic chip_sw_key_derivation_test
aa4031d 
keymgr_key_derivation_test_fpga_cw310_sival_rom_ext test was marked as
broken in lowRISC#21706. This commit fixes this and addresses lowRISC#21500.

The source of the bug is due to the nature of the ROM_EXT that runs
through a CDI attestation flow advancing the key manager state to
"OwnerRootKey" in the process. This was not accounted for in the test,
which assumed an active "CreatorRootKey" state (this works for sim_dv
tests but not with ROM_EXT). The solution to this issue lies in
rendering the test state-agnostic, meaning it will execute its
verifications independently of the current key manager state. This
approach thus mimics the keymgr_sideload_{aes,kmac,otbn} tests which
follow a similar strategy.

Signed-off-by: Andrea Caforio <[email protected]>
jwnrt pushed a commit that referenced this issue Oct 10, 2024
@andrea-caforio @jwnrt
[sival, keymgr] State-agnostic chip_sw_key_derivation_test
913c56f 
keymgr_key_derivation_test_fpga_cw310_sival_rom_ext test was marked as
broken in #21706. This commit fixes this and addresses #21500.

The source of the bug is due to the nature of the ROM_EXT that runs
through a CDI attestation flow advancing the key manager state to
"OwnerRootKey" in the process. This was not accounted for in the test,
which assumed an active "CreatorRootKey" state (this works for sim_dv
tests but not with ROM_EXT). The solution to this issue lies in
rendering the test state-agnostic, meaning it will execute its
verifications independently of the current key manager state. This
approach thus mimics the keymgr_sideload_{aes,kmac,otbn} tests which
follow a similar strategy.

Signed-off-by: Andrea Caforio <[email protected]>
@andrea-caforio
Copy link
Contributor

Addressed in #24755.

@jwnrt jwnrt changed the title [chip-test, keymgr] chip_sw_keymgr_key_derivation [chip-test] chip_sw_keymgr_key_derivation Oct 28, 2024
github-actions bot pushed a commit that referenced this issue Nov 13, 2024
@andrea-caforio @github-actions
[sival, keymgr] State-agnostic chip_sw_key_derivation_test
4fd78f9 
keymgr_key_derivation_test_fpga_cw310_sival_rom_ext test was marked as
broken in #21706. This commit fixes this and addresses #21500.

The source of the bug is due to the nature of the ROM_EXT that runs
through a CDI attestation flow advancing the key manager state to
"OwnerRootKey" in the process. This was not accounted for in the test,
which assumed an active "CreatorRootKey" state (this works for sim_dv
tests but not with ROM_EXT). The solution to this issue lies in
rendering the test state-agnostic, meaning it will execute its
verifications independently of the current key manager state. This
approach thus mimics the keymgr_sideload_{aes,kmac,otbn} tests which
follow a similar strategy.

Signed-off-by: Andrea Caforio <[email protected]>
(cherry picked from commit aa4031d)
luismarques pushed a commit that referenced this issue Nov 14, 2024
@andrea-caforio @luismarques
[sival, keymgr] State-agnostic chip_sw_key_derivation_test
ecae95b 
keymgr_key_derivation_test_fpga_cw310_sival_rom_ext test was marked as
broken in #21706. This commit fixes this and addresses #21500.

The source of the bug is due to the nature of the ROM_EXT that runs
through a CDI attestation flow advancing the key manager state to
"OwnerRootKey" in the process. This was not accounted for in the test,
which assumed an active "CreatorRootKey" state (this works for sim_dv
tests but not with ROM_EXT). The solution to this issue lies in
rendering the test state-agnostic, meaning it will execute its
verifications independently of the current key manager state. This
approach thus mimics the keymgr_sideload_{aes,kmac,otbn} tests which
follow a similar strategy.

Signed-off-by: Andrea Caforio <[email protected]>
(cherry picked from commit aa4031d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrea-caforio andrea-caforio

Labels
Component:ChipLevelTest Used to filter the chip-level test backlog IP:keymgr Priority:P2 Priority: medium SiVal:Autogen Generated by script
Projects
None yet
Milestone
Earlgrey ES SV3
Development

No branches or pull requests
3 participants
@johngt @moidx @andrea-caforio