Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hmac] V1 Signoff #21031

Closed
msfschaffner opened this issue Jan 25, 2024 · 3 comments · Fixed by #22340
Closed

[hmac] V1 Signoff #21031

msfschaffner opened this issue Jan 25, 2024 · 3 comments · Fixed by #22340
Assignees
Labels
Component:DV DV issue: testbench, test case, etc. IP:hmac Type:Signoff

Comments

@msfschaffner
Copy link
Contributor

Description

Ensure V1 signoff criteria are fulfilled after focus area changes have landed.

@msfschaffner msfschaffner added this to the Earlgrey-PROD.M2 milestone Jan 25, 2024
@msfschaffner msfschaffner added the Component:DV DV issue: testbench, test case, etc. label Jan 25, 2024
@andreaskurth
Copy link
Contributor

hmac_smoke passes 100% according to current nightly results. The only other V1 checklist item I think needs a more detailed look is TESTPLAN_COMPLETED to check that the RTL changes since Earlgrey-ES TO are covered by an existing test or captured in the testplan. According to the D2S signoff analysis, the main changes are:

Thus, I think we can sign off hmac at V1 once we have added the items above to the testplan. I'd create a PR to do both and close this issue. Do you agree, @gdessouky?

@gdessouky
Copy link
Contributor

Thanks @andreaskurth I agree, we can sign off HMAC at V1. These open DV issues capture what is left for M4, and I've also just edited #21708 with a couple more TODOs wrt testing unsupported modes.

@vogelpi
Copy link
Contributor

vogelpi commented Mar 28, 2024

The proposed plan of actions sounds good to me @andreaskurth . Let me know when the testplan PR is ready and I am happy to approve it.

andreaskurth added a commit to andreaskurth/opentitan that referenced this issue Mar 29, 2024
See lowRISC#21031 for the signoff analysis.  Closes lowRISC#21031.

Signed-off-by: Andreas Kurth <[email protected]>
andreaskurth added a commit to andreaskurth/opentitan that referenced this issue Mar 29, 2024
See lowRISC#21031 for the signoff analysis.  Closes lowRISC#21031.

Signed-off-by: Andreas Kurth <[email protected]>
andreaskurth added a commit that referenced this issue Mar 29, 2024
See #21031 for the signoff analysis.  Closes #21031.

Signed-off-by: Andreas Kurth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:DV DV issue: testbench, test case, etc. IP:hmac Type:Signoff
Projects
None yet
5 participants