Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spi_device,rtl] Handle SRAM integrity error output decisively #18353

Open
hcallahan-lowrisc opened this issue May 5, 2023 · 3 comments
Open
Assignees
Labels
Component:RTL Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:spi_device Priority:P2 Priority: medium Type:Icebox Changes deferred to future milestones
Milestone

Comments

@hcallahan-lowrisc
Copy link
Contributor

Description

// TODO: Handle SRAM integrity errors
sram_err_t unused_sram_rerror;
assign unused_sram_rerror = sram_m2l_i.rerror;

e.g.

  1. Update comment to explain decision to leave unconnected
  2. Create an alert from this signal
  3. ...
@hcallahan-lowrisc hcallahan-lowrisc added Component:RTL IP:spi_device Type:Icebox Changes deferred to future milestones labels May 5, 2023
@msfschaffner msfschaffner added the Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones label Oct 7, 2023
@msfschaffner msfschaffner added this to the Earlgrey-PROD.M2 milestone Nov 7, 2023
@msfschaffner msfschaffner added the Priority:P2 Priority: medium label Dec 4, 2023
@a-will
Copy link
Contributor

a-will commented Jan 8, 2024

Just a note: If we make this an alert, we'll also need to have firmware completely initialize the accessible regions of the RAM, including "unused" portions of accessible regions, and document this in the programming guide.

Hosts may choose to read unused areas of the SFDP array, for example, and unless those are initialized to a known value, the alert could trigger from innocent behavior.

@msfschaffner
Copy link
Contributor

Given that this is not a security IP, I am not sure this needs to be a fatal alert.
On the bus side, we just send back a tlul bus error in case the parity of a SPI_DEVICE SRAM access is wrong.
We could potentially trigger a regular error + interrupt if this happens.

@msfschaffner
Copy link
Contributor

Discussed with @a-will and we think it is fine to put this in the backlog for now, given that this is not a security IP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:RTL Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:spi_device Priority:P2 Priority: medium Type:Icebox Changes deferred to future milestones
Projects
None yet
Development

No branches or pull requests

3 participants