[dv,py] Tweak ISS linker arg construction for Xcelium #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcallahan-lowrisc
added
the
Component:DV
hcallahan-lowrisc
force-pushed
the
core_ibex_dv_xcelium_iss_flags
branch
from
4e23e1a
to
cf0c359
Compare
hcallahan-lowrisc
force-pushed
the
core_ibex_dv_xcelium_iss_flags
branch
from
cf0c359
to
96aef9e
Compare
rswarbrick
reviewed
Oct 1, 2024
The previous code here was a bit too hacky, so implement a solution that directly follows the suggestion in the Cadence support article. An example was also added to make it clear what this transformation is achieving. Add some more typehints, and cleanup names. Signed-off-by: Harry Callahan <[email protected]>
Add comments, and move some variable declarations around to be closer to their use. Signed-off-by: Harry Callahan <[email protected]>
hcallahan-lowrisc
force-pushed
the
core_ibex_dv_xcelium_iss_flags
branch
from
96aef9e
to
c9660e5
Compare
rswarbrick
approved these changes
Oct 1, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code here was a bit too hacky, so implement a solution that directly follows the suggestion in the Cadence support article. An example was also added to make it clear what this transformation is achieving.
Additionally, cleanup some of the other code in the module, renaming for clarity and adding comments. Move some variable declarations around to be closer to their use. Add some more typehints.
Fixes #2205