-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using semantic versioning #1754
Comments
PS - I like this new version. 👍 |
Hello, did you see #1448 (comment) ? The tl;dr is that sharp v0.y.z not only conforms to but exceeds semver. |
Hi @lovell I did not see that comment, thank you for pointing it out.
Unless I'm missing something,
I'm missing something. The documentation says:
So theoretically you're correct. However, I am observing across three different node and npm versions that this is not working as intended. This issue is empirical rather than theoretical. At the same time, I don't believe npm would have this issue persist over a long period, so I trust that somehow this is my own fault. I hope 1.0.0 will be released soon, because it would fix some issues for me. |
If anyone comes across this issue, I've done an
|
https://semver.npmjs.com/ is a useful tool to understanding semver as applied by npm. |
sharp
breaks my (re)deploy sometimes, because it doesn't mark breaking changes as 'major'.One could argue that I need to change my
package.json
and lock versions. On the other hand, the default fornpm install package --save
is semantic versioning where minor and patch releases are installed automatically, and the major version is locked by default, AKA^x.y.z
.Today (applause for the app running over six months) it was #1392. This is a breaking change.
Please consider using the first digit in the version number, and increase it when a breaking change is made.
I know in my specific case that would mean you'd be at 3.x.x now, and I know some people do not feel comfortable using version numbers above or equal to 1.0.0 as it implies commercial-grade stability, but it's okay.
Just do it:
Changelog
1.0.0
Bam! 🎆
The text was updated successfully, but these errors were encountered: