Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps: heif, mozjpeg #196

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Conversation

kleisauke
Copy link
Collaborator

FWIW, the libheif bump to v1.17.0 might be a bit too risky/early, see e.g.:
strukturag/libheif@v1.17.0...master

Specifically the fix in commit strukturag/libheif@18d4e55, which would otherwise prevent AVIF images with premultiplied alpha channels from being decoded.

@lovell
Copy link
Owner

lovell commented Oct 17, 2023

Yeah, there were a lot of libheif changes just before the latest version was published that are unlikely to have seen enough fuzz testing yet. Those CMake failures should go away if we switch this PR to target the upgrade-linux-containers branch.

@kleisauke kleisauke changed the base branch from main to upgrade-linux-containers October 17, 2023 18:22
@kleisauke
Copy link
Collaborator Author

Re-targeted to the upgrade-linux-containers branch instead. Commit d51dd3b is still needed for Debian Buster (an alternative for this would be to upgrade the container to debian:buster-backports, which provides CMake 3.18.4).

@lovell lovell merged commit a8141b9 into lovell:upgrade-linux-containers Oct 18, 2023
12 checks passed
@lovell
Copy link
Owner

lovell commented Oct 18, 2023

Thanks Kleis. I suspect there'll be a patch version of libheif along very soon.

lovell pushed a commit that referenced this pull request Oct 18, 2023
Reduce CMake requirement to ensure heif compiles on Debian 10
@kleisauke kleisauke deleted the bump-deps branch October 19, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants