Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix embedding #259

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Fix embedding #259

merged 2 commits into from
Dec 10, 2023

Conversation

marclurr
Copy link
Contributor

@marclurr marclurr commented Dec 9, 2023 •
edited
Loading

Fixes #258

Subtle bug introduced by the fix for #254 means that the code which configures the activity to load the game.love file into the cache is no longer reachable. Thss moves the initialisation of needToCopyGameInArchive into onCreate and removes the unreachable code from handleIntent

@MikuAuahDark MikuAuahDark merged commit a81931b into love2d:main Dec 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embed builds no longer work
2 participants
@marclurr @MikuAuahDark