Component should update when className is changed

[WendellLiu]

it will make this component flexible to make some style change

[Treora]

Looks good to me, I can't think of cases where this would harm.

As I wrote yesterday:

perhaps we should think about a more general way to check for changes in props that are passed through to the element. Should the component perhaps update if any prop has changed, except if our tests find that the change is already reflected in the DOM?

I would suggest to merge this for now, and possibly later we can try out if updating on every prop change not related to innerHTML would indeed be an improvement.

[eugene1g]

In the same spirit, it would be great to reflect changes in style prop as well.

[monolithed]

It can be implemented something like:

{
	shouldComponentUpdate (nextProps) {
		let { props, htmlEl } = this;

		// We need not rerender if the change of props simply reflects the user's edits. 
		// Rerendering in this case would make the cursor/caret jump.

		// Rerender if there is no element yet... (somehow?)
		if (!htmlEl) {
			return true;
		}

		// ...or if html really changed... (programmatically, not by user edit)
		if (nextProps.html !== htmlEl.innerHTML && nextProps.html !== props.html) {
			return true;
		}

		let optional = ['style', 'className', 'disable'];

		// Handle additional properties
		return optional.some(name => props[name] !== nextProps[name]);
	}
}

[ajbeaven]

Can this be merged please?

[Treora]

I get the impression nobody is actively maintaining this project anymore.. Neither am I, but I can still press the merge button if that helps anyone. I am not able to publish a release update however, I guess you may have to kindly poke @lovasoa for that.