Add mypy and update typings #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloria
commented
Sep 20, 2019
|
Great ! @karlb, you finally get correct types for this library :) |
lovasoa
requested changes
Sep 20, 2019
|
Cool, thanks! |
lovasoa
approved these changes
Sep 20, 2019
|
@lovasoa Shall I merge my own PRs after you approve or would you like to do that? |
|
@sloria, you can merge your own PRs ! |
|
OK, I'll squash and merge after your approval from now on. I'll be responsive most days, but of course, no need to block on me--feel free to merge when it's practical. |
|
The same for me. Feel free to merge things if I'm not responsive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this package distributes types, it'd be good to ensure that they're correct. This adds mypy to the pre-commit config and updates type annotations to pass mypy's type checks.