This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Fix setting threshold and recurrence on update #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@louy hi any update on this? I can also try remove the copy/paste block but I think it might be a bit over kill. |
|
Yeah don't worry about it. Let me get this merged and published |
|
Sadly can't add an automated test either because it would require a paid account. I guess we'd have to leave the test as is |
|
Thanks! I am more actively working on this I can try to revisit #57 I will contact uptimerobot directly and see what their support says. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes setting the
thresholdandrecurrenceproperties when a monitor changes.Some things to note.
thresholdandrecurrenceas part of the plan loop this will only work when you update the code/state. There is no way for this provider currently to detect a difference between the uptime robot config in uptime robot and this state.