This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Remove ForceNew on url param fixes #11 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to update urls on a monitor
aleksgain
pushed a commit
to Revolgy-Business-Solutions/terraform-provider-uptimerobot
that referenced
this pull request
Feb 17, 2023
fix provider crash if http_method parameter is not sent over HTTP res…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to update urls on a monitor.
I am not 100% sure how to udpate the tests, but I did rebuild the plugin and tested it works with my code. I was able to update urls on a monitor.
Do you have any advice on how to update the tests to support this?
References #11