Add GeoBoundingBox filter #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toflar
reviewed
Sep 17, 2024
alexander-schranz
force-pushed
the
feature/geo-bounding-box-filter
branch
from
5f10424
to
dc88b89
Compare
alexander-schranz
force-pushed
the
feature/geo-bounding-box-filter
branch
from
fc86f25
to
bcf1922
Compare
|
@Toflar ready for review |
Toflar
reviewed
Sep 18, 2024
Toflar
reviewed
Sep 18, 2024
| '_geoBoundingBox(location, 1.00 2.00, 2.00, 3.00)', | ||
| "Col 31: Error: Expected ',', got '2.00'", | ||
| ]; | ||
|
|
There was a problem hiding this comment.
Just one more test for invalid coordinates would be great :)
|
Oh and some docs on how to use the filter https://github.com/loupe-php/loupe/blob/main/docs/searching.md#filter |
alexander-schranz
force-pushed
the
feature/geo-bounding-box-filter
branch
from
9150db5
to
df140d9
Compare
Toflar
reviewed
Sep 18, 2024
Co-authored-by: Yanick Witschi <[email protected]>
|
Thanks @alexander-schranz! This is very cool! I'm going to clean up some stuff and then release it as v0.7 :) |
|
@Toflar Awesome. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why Loupe already supports filtering by a GeoDistance. Which support we already merged also int SEAL. It would also be nice to filter by a bounding box (rectangle). That is mostly used for things when a user navigates around a map and have a specific area shown.
See fore more information: #83
fixes #83
Implemented as far as I could get with my knowledge.