Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing JSDoc comments #2549

Merged
merged 5 commits into from
Jan 15, 2023

Conversation

Computroniks
Copy link
Contributor

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

After a number of PRs have been merged, some of the JSDoc comments are missing. This PR should add comments for all the functions / methods that were missing.

Type of change

Please delete any options that are not relevant.

  • Documentation

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings

Signed-off-by: Matthew Nickson <[email protected]>
Signed-off-by: Matthew Nickson <[email protected]>
Signed-off-by: Matthew Nickson <[email protected]>
Copy link
Contributor

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

extra/update-wiki-version.js Outdated Show resolved Hide resolved
server/uptime-kuma-server.js Outdated Show resolved Hide resolved
server/uptime-kuma-server.js Show resolved Hide resolved
@louislam louislam added this to the 1.19.5 milestone Jan 11, 2023
@louislam louislam changed the base branch from master to 1.19.X January 15, 2023 05:09
@louislam louislam merged commit 49ac71e into louislam:1.19.X Jan 15, 2023
@Computroniks Computroniks mentioned this pull request Aug 6, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants