Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement for big select + bugfix #180

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improvement for big select + bugfix #180

wants to merge 5 commits into from

Conversation

codesource
Copy link

I improved generation of multi-select for big select to answer to #58 (comment)

I tested with 10000 items, it takes 3secs.
Optgroups's initialization is not optimized but the script works with them.

I corrected a bug that didn't accept <option with integer value and made

  • id more WC3.

    •

    matthias added 4 commits March 20, 2015 22:33
    [FEATURE] Improve initial rendering for big select
    de3ab83 
    To prevent browser's freezing, all "<li>" are created as text element without using jQuery and are added to DOM only at end of generation.
    [BUGFIX] Option value can't be a integer
    90b922f 
    Option value as integer can't be selected/deselected and <li> id attribute is not W3C.

<li> id has been prefixed with "ms-elem-" to be W3C and not start with an integer.
    [TASK] Renaming function generateLisFromOption to generateListFromOption
    23d094b
    [BUGFIX] Option groups are not rendering with improved version
    04c8226
    @manmanwu18
    Copy link

    @codesource
    Thank you very much, you resolved my problem which troubles me for a week.
    Suggest you can @lou , and merge your code master branch. I think there are many students encounter the same issue.

    @RobArch
    Copy link

    RobArch commented Jan 13, 2020

    Is anyone able to resolve the conflicts and get these changes merged into the master branch?

    @codesource
    Copy link
    Author

    @RobArch There hasn't been any news from the main author @lou for many years.
    I haven't followed the project for some time, but it is certainly fixable.
    I don't have time now to resolve the conflicts, but I will try to take some time and get back into the code.

    @RobArch
    Copy link

    RobArch commented Jan 14, 2020

    @RobArch There hasn't been any news from the main author @lou for many years.

    Thanks for offering to look at the changes. I've used the pull request as-is and it's working. If there are better components like this one that are maintained, let me know.

    Thanks again.

    @codesource
    Copy link
    Author

    Resolved all conflict with master branch

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @codesource @manmanwu18 @RobArch @phule