This repository has been archived by the owner on Apr 23, 2023. It is now read-only.
Unregister callbacks #208
Merged
Unregister callbacks #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
msmollin
suggested changes
May 23, 2017
| @@ -133,6 +133,7 @@ private void removeGeofences(LostApiClient client, String geofenceRequestId) | |||
| @RequiresPermission(anyOf = {ACCESS_COARSE_LOCATION, ACCESS_FINE_LOCATION}) | |||
| @Override public PendingResult<Status> removeGeofences(LostApiClient client, | |||
| PendingIntent pendingIntent) throws SecurityException { | |||
|
|
|||
There was a problem hiding this comment.
Minor nit: remove if not needed.
msmollin
approved these changes
May 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds
LostApiClient#unregisterConnectionCallbacksso that developers can prevent leaking resources when adding callbacks inLostApiClient.Builder.addConnectionCallbacksIt also updates the sample app examples to use cleanup registered callbacks.
Future work will add
LostApiClient#registerConnectionCallbacksto allow adding callbacks after the client has been createdCloses #206