-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to SDK-based csproj files #17
Conversation
Turn off Pointer<T> debug code for net35. Cherry-picked from 5efeee5
The PCL build has been readded, but it will only build from Visual Studio or full MSBuild. |
First off, thanks for the help. Sorry I haven't had much time to look at this in-depth yet but I did have one question to start with: do you have any suggestions for how to distribute the unsafe library? It seems on nuget I've seen 3 patterns:
|
Also to explain the PCL build: It's there because Windows / Windows Phone 8.1 projects seem to break in really strange ways when they try and import a NetStandard library using the older 2013/2015 toolchain. Like, compile would work fine, but then something with ARM IL code generation would break when you tried to deploy it to a device. It looks like you added back PCL support which is much appreciated. |
No worries, I think we all know what it's like to be busy.
I was wondering about the need for the PCL build. I didn't know how to enable it at first, so I removed it until I figured out how to add the build. I saw that .NET Standard support was added to VS2013/2015, but didn't know if some tools still had issues with the .NET Standard assemblies. |
I'm guessing it's not possible to also maintain the old-format project files, perhaps as a separate solution? Almost all of my machines have VS2015 at the latest and I'm, uh, too lazy to upgrade all of them |
It's definitely possible if you want to go that route. If there were two solutions, it would mainly be more work if you wanted to add a new project in the future or something. |
Before I spend the time to create 2 separate solutions, is that something that would be acceptable? |
Sorry, I've kept you waiting long enough. I'm just going to merge this and then work out my own solution files later (or just migrate to vs2017 on my side I guess) |
This migrates all csproj files except ConcentusDemo to the newer csproj format.
Concentus
andConcentus.Unsafe
. Both of these projects target multiple frameworks.There are a couple things to look over. Let me know if I need to change any of these.
I saw your release notes about removing the net35 build from the latest NuGet package. I'm assuming that was because .NET Framework targets would choose the net35 build over the netstandard1.0 build. I added a net45 build so that wouldn't be an issue, and readded the net35 build.
I did my best to make sure all the build outputs were the same after the transition, but there's one difference with the .nuspec file. Csproj files don't have an option to set the summary in the nuspec file. (NuGet/Home#4587) I don't know if that's a problem or not.
I had to remove the PCL build. If the cross-platform MSBuild supports targeting PCLs, I'm not sure how to do it, and netstandard1.0 supports all the platforms that Profile259 does.