-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable JSON encoders and decoders #1539
Configurable JSON encoders and decoders #1539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for moving this contribution 🙏 !
I've left some minor comments to be addressed, but overall this looks good, well test-covered and documented 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more minor changes, sorry for being picky 🙏!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for patiently addressing all my comments, LGTM 🎉 !
Take, a digital 🍺 ! |
Moves lostisland/faraday_middleware/#286
By default
Faraday::Request::Json
andFaraday::Response::Json
usejson
to encode/decode JSON data, although there are gems likeoj
which do the job faster than Ruby's built-injson
.This implementation allows to pass
encoder
option toFaraday::Request::Json
and decoder option to pass in parser_options toFaraday::Response::Json