Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying connection name #26

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

cocoahero
Copy link
Contributor

Allows you to pass a name: option to the adapter which is used when initializing the cached connection. This is useful when you have multiple Faraday clients using HTTP persistent, but need to tell them apart in traces, metrics, and so forth.

@iMacTia iMacTia merged commit cda3e8b into lostisland:main Oct 7, 2024
7 checks passed
@iMacTia
Copy link
Member

iMacTia commented Oct 7, 2024

Nice and simple, with test coverage.
LGTM, thank you @cocoahero 🙏 !

@cocoahero cocoahero deleted the jbaker/name-option branch October 7, 2024 14:37
@cocoahero
Copy link
Contributor Author

🙏🏼 @iMacTia - any idea on a timeline for getting this in a release?

@iMacTia
Copy link
Member

iMacTia commented Oct 7, 2024

Just trying to get #24 in as well so I can release it together with this 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants