Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH add show_lines to plot_marginal #186

Merged
merged 2 commits into from
Nov 12, 2024
Merged

ENH add show_lines to plot_marginal #186

merged 2 commits into from
Nov 12, 2024

Conversation

lorentzenchr
Copy link
Owner

@lorentzenchr lorentzenchr commented Nov 9, 2024 •
edited
Loading

Fixes #177.
plot_marginal gets a new argument show_lines with options:

  • "always"
  • "numerical"

@lorentzenchr lorentzenchr requested a review from mayer79 November 10, 2024 17:55
mayer79
mayer79 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@mayer79 mayer79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was thinking about the argument options "numeric" instead of "numerical", but that is a detail.

@lorentzenchr
Copy link
Owner Author

Looking up some sources for English, it seem it is a "numerical feature", therefore numerical.

@mayer79 mayer79 merged commit ab620c2 into main Nov 12, 2024
5 checks passed
@lorentzenchr lorentzenchr deleted the show_lines branch November 12, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayer79 mayer79 mayer79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH Show optional lines in plot_marginal() et al
2 participants
@lorentzenchr @mayer79