Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROS 2 Jazzy Jalisco #410

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Add ROS 2 Jazzy Jalisco #410

merged 1 commit into from
Jul 6, 2024

Conversation

wentasah
Copy link
Contributor

The content of jazzy/overrides.nix is just a copy of rolling/overrides.nix.

At least ros-core builds successfully (tested on files generated by superflore today; not yet in this repo).

The content of jazzy/overrides.nix is just a copy of
rolling/overrides.nix.

At least ros-core builds successfully (tested on files generated by
superflore today; not yet in this repo).
@hacker1024
Copy link
Contributor

hacker1024 commented Jun 16, 2024

Perhaps we should use Python 3.12 here as well? REP 2000 uses a range of 3.7 - 3.12, depending on the platform, with 3.8 and 3.12 being hard requirements.

@wentasah
Copy link
Contributor Author

I'm not sure. I think that historically, the python attribute was used in this repo only to distinguish between Python 2 and 3. Given that Jazzy will be supported 5 years, it will likely be longer than how long will Python 3.12 stay in nixpkgs. Therefore, keeping this overlay up-to-date with what's the default in nixpkgs seems more practical to me.

@hacker1024
Copy link
Contributor

Fair enough. 3.12 will also become the default at some point in the near future: NixOS/nixpkgs#320924

@lopsided98 lopsided98 merged commit 9674e12 into lopsided98:develop Jul 6, 2024
@wentasah wentasah deleted the jazzy branch July 6, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants