-
Notifications
You must be signed in to change notification settings - Fork 86
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This fixes a freeze when adding more than one light.
- Loading branch information
1 parent
22d0db7
commit b1a844a
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1a844a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a reproducer for this?
ogre_1_9
has been recently dropped: NixOS/nixpkgs#222564Or do you remember why you reverted the 1.12 bump? a405f62
b1a844a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #260
Nixpkgs currently has Ogre 1.10 and 13. Gazebo fails to build with 13. Gazebo more or less works with 1.10, but adding more than one light causes it to freeze. There don't appear to be any plans to support newer versions, since Gazebo classic only has minimal maintenance now. I may have to maintain 1.9 in this overlay.