Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adding Durable Errors for Decoders #28

Merged
merged 7 commits into from
Sep 1, 2023
Merged

Conversation

ShivanshVij
Copy link
Member

Description

This PR fixes an issue where incorrectly decoding a polyglot buffer would break it - meaning future decodes would fail. Instead, this PR changes the underlying functionality of the code so that if an error occurs while decoding, it is possible to try decoding a different type.

Type of change

Please update the title of this PR to reflect the type of change. (Delete the ones that aren't required).

  • New feature (non-breaking change which adds functionality) [title: 'feat:']

Testing

N/A

Final Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have signed-off my commits with git commit -s (see the developer's certificate of origin)

Signed-off-by: Shivansh Vij <[email protected]>
Signed-off-by: Shivansh Vij <[email protected]>
Signed-off-by: Shivansh Vij <[email protected]>
Signed-off-by: Shivansh Vij <[email protected]>
Signed-off-by: Shivansh Vij <[email protected]>
Signed-off-by: Shivansh Vij <[email protected]>
Signed-off-by: Shivansh Vij <[email protected]>
Copy link
Contributor

@SuperManifolds SuperManifolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShivanshVij ShivanshVij merged commit fc57b23 into staging Sep 1, 2023
7 checks passed
@ShivanshVij ShivanshVij deleted the durable-errors branch September 1, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants